Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
631 commits
Select commit Hold shift + click to select a range
fb97a8b
update/add links (#37685)
mairaw May 16, 2019
a9cc03b
Make Label and OpCode readonly and IEquatable (dotnet/coreclr#24360)
GrabYourPitchforks May 16, 2019
9441b70
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 16, 2019
db5b11a
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 16, 2019
7e44240
Update ProjectNTfs to beta-27716-00 (#37698)
dotnet-maestro-bot May 16, 2019
5310b56
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] May 16, 2019
b885c22
Mark System.Reflection.Emit* as inbox on netstandard2.1 (#37532)
wtgodbe May 16, 2019
1b6f45c
Linux: ProcessName: return script name instead of interpreter program…
tmds May 16, 2019
ca9bf96
Update issue-guide.md
karelz May 16, 2019
4816cac
Fix Handling time patterns with quotes (dotnet/coreclr#24589)
tarekgh May 16, 2019
b1a1bfa
Use CancellationToken.UnsafeRegister in a few more places (#37551)
stephentoub May 16, 2019
3748331
Added failing test case for unexpected StackOverflowException
oskardudycz May 16, 2019
81291b0
Executing tests in a serial order (#37715)
Anipik May 16, 2019
02b3832
Add placeholder entry to global.json (#37675)
ViktorHofer May 16, 2019
75a6020
Update issue-guide.md
karelz May 16, 2019
2c22af8
Determine the anyAttribute Namespace based on the NamespaceList (#37409)
JosVerburg May 16, 2019
52c6527
Add [EnumeratorCancellation] to Microsoft.Bcl.AsyncInterfaces (#37719)
stephentoub May 16, 2019
026fa6a
Fixed deserialization of null arrays for issue #37606 (#37616)
gnovack May 16, 2019
d8797a0
Improve performance of Linux X509Chain building via caching
bartonjs May 16, 2019
4435d78
Fix a bug in xsd validation during deserialization (#37596)
jiayi11 May 17, 2019
05233fd
Fix ListenerWithFilter test (#37731)
stephentoub May 17, 2019
ef25246
Fix minor typo NanoSeconds -> nanoseconds (#37732)
gregkalapos May 17, 2019
f42e04b
Use Arcade DotNetTool and NuGetPackageRoot (#37647)
ViktorHofer May 17, 2019
18ddda0
Add interleaved comments to JSON tests (#37712)
watfordgnf May 17, 2019
6f9570e
Fix missing casts in Enumerable.Select assert (#37410) (#37699)
timandy May 17, 2019
6460947
Clean up usage of ArrayPool in the Cryptography assemblies
bartonjs May 17, 2019
71487a4
Add extension data support to Json serializer (#37690)
steveharter May 17, 2019
9643d42
Enable rolling builds and add arm64 in outerloop (#37728)
ViktorHofer May 17, 2019
9d59328
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] May 17, 2019
d1d8396
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 17, 2019
5e50662
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 17, 2019
2619560
Move runtests to eng and fix invocation (#37754)
ViktorHofer May 17, 2019
a4da51f
Unit tests for Path.Join overloads (#37285)
jbhensley May 17, 2019
c593210
Fix parameter names in ToUtf16 (dotnet/coreclr#24617) (#37741)
Dotnet-GitSync-Bot May 17, 2019
b578d19
Add resource containers missing in Outerloop.yml (#37761)
ViktorHofer May 17, 2019
959168e
Generate System.Runtime ref assembly against implementation (#37737)
safern May 17, 2019
d72d720
Consume comments changes (#35934)
WinCPP May 17, 2019
0dabda1
Correcting documentation for span and memory slice (dotnet/coreclr#24…
Anipik May 17, 2019
e30ab6c
Ensure using single Utc object in TimeZoneInfo (dotnet/coreclr#24614)
tarekgh May 17, 2019
3c8e1ff
[master] Update dependencies from dotnet/arcade (#37703)
dotnet-maestro[bot] May 17, 2019
c671ce2
Remove aliases (#37759)
Anipik May 18, 2019
963480a
Allow run Outerloop tests only (#37766)
ViktorHofer May 18, 2019
5052645
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 18, 2019
7da9cea
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 18, 2019
03a38b3
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 18, 2019
20bd7bb
Enable C# mode command line diff (#37767)
May 18, 2019
c93e46b
Fixing the Dragon4 algorithm to correctly handle when the first signi…
Dotnet-GitSync-Bot May 18, 2019
36ad1c6
Add IsVariableBoundArray to TypeDelegator (dotnet/coreclr#24637)
safern May 18, 2019
771b70f
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 19, 2019
f18cfc2
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 19, 2019
1ad66d3
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 19, 2019
d70ba24
Added value type serialization support (#36506)
YohDeadfall May 20, 2019
27dae83
Throw ArgumentException in JsonSerializer if ReadCommentHandling is A…
watfordgnf May 20, 2019
8261325
[System.Drawing] Fix cut & paste error (#37788)
filipnavara May 20, 2019
3029641
[master] Update dependencies from dotnet/standard (#37774)
dotnet-maestro[bot] May 20, 2019
e58b35c
SkipValidation when using the writer internally within the serializer…
ahsonkhan May 20, 2019
1897667
Add string-based WriteAsProperty overload to JsonElement. (#37789)
ahsonkhan May 20, 2019
8894917
Fix testscope usage in yml and sh script (#37805)
ViktorHofer May 20, 2019
5b61cc8
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 20, 2019
4694946
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] May 20, 2019
4a79484
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 20, 2019
853f11e
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 20, 2019
7373fd9
Update ProjectNTfs to beta-27720-00 (#37792)
dotnet-maestro-bot May 20, 2019
3ff5c4a
Ensure JsonException is thrown parsing invalid DateTime, DateTimeOffs…
watfordgnf May 20, 2019
e4c0911
Avoid boxing in TextWriter.Write(StringBuilder) (dotnet/coreclr#24664…
Dotnet-GitSync-Bot May 20, 2019
2e1d93e
Generate System.Runtime.Extensions reference assembly against impleme…
safern May 20, 2019
8b557c6
Enable determinism mode (#37677)
ViktorHofer May 20, 2019
5f61457
Update docs with Outerloop changes
ViktorHofer May 20, 2019
e94ff8a
Update supported architectures on Windows in docs
ViktorHofer May 20, 2019
f403c57
Converting SystemColors into InstanceDescriptors using Color Converto…
Anipik May 20, 2019
c85411a
[master] Update dependencies from dotnet/coreclr (#37746)
dotnet-maestro[bot] May 21, 2019
ef1a5aa
Add Microsoft.Private.CoreFx.OOB package (#37784)
ViktorHofer May 21, 2019
53aaaf3
Implement GetComment API (#35705)
WinCPP May 21, 2019
11eba79
Reenable ModifyStore tests (#37827)
ViktorHofer May 21, 2019
51a1f16
As Span and As Memory apis added for immutable arrays (#37757)
Anipik May 21, 2019
b3ac650
Adding some additional tests to validating formatting is correct with…
tannergooding May 21, 2019
0f22cd0
Enhance the Missing Resources Exception Message (dotnet/coreclr#24645)
tarekgh May 21, 2019
a70f241
Update ProjectNTfs to beta-27721-00 (#37832)
dotnet-maestro-bot May 21, 2019
85e0712
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 21, 2019
76f1a30
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 21, 2019
e52d899
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 21, 2019
611db6d
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] May 21, 2019
76d1a05
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-maestro[bot] May 21, 2019
857d1d1
Avoid StackOverflowException when cyclic enumerable Type (#37818)
steveharter May 21, 2019
008d21c
Exclude non netcoreapp packages from OOB package (#37845)
ViktorHofer May 21, 2019
39c7df8
Add Utc test to ensure creating only one instance (#37721)
tarekgh May 21, 2019
4c5a775
Publish corefx tests for more platforms
BruceForstall May 21, 2019
99267e7
Reduce overhead of SemaphoreSlim.WaitAsync (dotnet/coreclr#24687)
stephentoub May 21, 2019
8d04281
Update packageIndex.json with packages from release branches (#37600)
joperezr May 21, 2019
2016619
Fix ambiguous Utf8JsonReader Get/TryGet method documentation (#37779)
Wildenhaus May 22, 2019
85d82a0
Regression test for multiple attributes on the same type (#37518)
jkotas May 22, 2019
b9b357f
Modified format logic so that braces are not allowed in custom format…
mikernet May 22, 2019
ee35d4f
using netcoreapp2.1 version if colorUtil (#37854)
Anipik May 22, 2019
bf1223b
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 22, 2019
a0aac7a
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] May 22, 2019
62951c4
Update ProjectNTfs to beta-27722-00 (#37859)
dotnet-maestro-bot May 22, 2019
716fbb1
Implement AppDomain.Monitoring*MemorySize (dotnet/coreclr#24610)
stephentoub May 22, 2019
05d3aaa
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-maestro[bot] May 22, 2019
dacb04d
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 22, 2019
39315f8
[master] Update dependencies from dotnet/standard (#37847)
dotnet-maestro[bot] May 22, 2019
7432f96
Merge pull request #37851 from BruceForstall/PublishMoreCorefxTests
BruceForstall May 22, 2019
23d3b1b
Update area owners for System.IO.Pipelines
karelz May 22, 2019
6f6790f
initial support for new network protocols (#37315)
wfurt May 22, 2019
40197ab
Update issue-guide.md
karelz May 22, 2019
a28444b
Fix threading issue when reading and writing from SslStream at the sa…
krwq May 22, 2019
eae78cb
Fix powershell command invocation for test (#37871)
ViktorHofer May 22, 2019
c8e1416
Use netfx ref package from nuget (#37869)
ViktorHofer May 22, 2019
9963d52
Remove LanguageTargets switch (#37875)
ViktorHofer May 22, 2019
44df70f
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] May 23, 2019
58c30f7
Use RepoTools instead of global tools (#37858)
ViktorHofer May 23, 2019
9468757
Commit 29810a78e5b93d8da9fb921d096226d249fc75a5 added unconditional d…
marek-safar May 22, 2019
0b8a72e
Fix Path.Join argument nullable annotation (dotnet/coreclr#24719)
stephentoub May 22, 2019
daa005b
Update to new compiler toolset by using arcade's property (#37883)
safern May 23, 2019
97fb32c
Update ProjectNTfs to beta-27723-00 (#37887)
dotnet-maestro-bot May 23, 2019
510ab9e
Add logging at the Task timeout tests (#37874)
tarekgh May 23, 2019
e8c66ae
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 23, 2019
7946bfe
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 23, 2019
2fc59ab
Fix CoreRT build breaks
jkotas May 23, 2019
41489a9
Add nowarns for reference assemblies to be annotated with nullable wa…
safern May 23, 2019
025bb33
Support unlimited array dimensions (#37867)
steveharter May 23, 2019
5733747
Fix typo in JsonSerializer api documentation. (#37917)
ahsonkhan May 24, 2019
36a8ed9
Fewer ilstubs in corelib from reflection apis (dotnet/coreclr#24708)
davidwrighton May 23, 2019
c539d6c
Address #37794 by removing "UTF-16" when not needed in System.Text.Js…
watfordgnf May 24, 2019
48e4613
Delete FEATURE_TESTHOOK (dotnet/coreclr#24746)
jkotas May 24, 2019
ec7a779
Make AppDomain.GetThreadPrincipal() internal (dotnet/coreclr#24747)
safern May 24, 2019
cbc9701
fix #36798 by updating PipeReader doc comment (#37919)
analogrelay May 24, 2019
b63b6f8
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 24, 2019
2fe8638
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 24, 2019
555d6e7
Update ProjectNTfs to beta-27724-00 (#37921)
dotnet-maestro-bot May 24, 2019
58d1cd2
Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, r…
dotnet-maestro-bot May 24, 2019
4e342b9
rename ToBytes to ToUtf8Bytes (#37912)
Anipik May 24, 2019
af031b0
[master] Update dependencies from dotnet/standard (#37891)
dotnet-maestro[bot] May 24, 2019
564ced2
Re-generate System.Runtime.InteropServices ref source against impleme…
safern May 24, 2019
47d169a
[master] Update dependencies from dotnet/corefx (#37890)
dotnet-maestro[bot] May 24, 2019
3232bbd
Fix binary bitwise operators with resized BitArray (#37876)
Gnbrkm41 May 24, 2019
bf7dbd6
Use Thread instead of Task.Run in some Task tests (#37932)
tarekgh May 24, 2019
94171e0
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 24, 2019
6dedc95
Fix nullable annotation in Array.SetValue
safern May 24, 2019
1262652
Fix Guid.TryParse nullabel annotation
safern May 24, 2019
c7a75c3
Fix nullable annotation in String.Join
safern May 24, 2019
ca53517
Fix nulable annotations build break (dotnet/coreclr#24768)
jkotas May 24, 2019
3838e8d
Update dependencies from https://github.com/dotnet/arcade build 20190…
May 25, 2019
a59cb1a
Update xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProper…
krwq May 25, 2019
51567c4
Stop nulling out lock object in SemaphoreSlim (dotnet/coreclr#24776)
stephentoub May 26, 2019
9bc507c
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 27, 2019
5ae791a
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 27, 2019
c31734a
Remove custom restore for arcade
ViktorHofer May 27, 2019
ba19505
Update ProjectNTfs to beta-27727-00 (#37961)
dotnet-maestro-bot May 27, 2019
5dd3196
Merge pull request #37950 from dotnet/darc-master-201ad320-f5b9-4f45-…
ViktorHofer May 27, 2019
d58a8ad
Move tests with external servers to outerloop (#37934)
wfurt May 27, 2019
248f095
Move dotnet-tools config
ViktorHofer May 23, 2019
13ce381
Add restore source for repo tools
ViktorHofer May 27, 2019
6033b11
Update ProjectNTfs to beta-27728-00
dotnet-maestro-bot May 28, 2019
8d1149c
Merge pull request #37975 from dotnet-maestro-bot/master-UpdateDepend…
ViktorHofer May 28, 2019
09984f2
Call derived ToString on inner exceptions (dotnet/coreclr#24793)
danmoseley May 28, 2019
f90b73e
[master] Update dependencies from dotnet/coreclr (#37953)
dotnet-maestro[bot] May 28, 2019
1064d03
User-Agent header is ignored in "CONNECT" requests (#37785)
MarcoRossignoli May 28, 2019
2f2aca4
Add Skip and TrySkip APIs to Utf8JsonReader with tests. (#37793)
ahsonkhan May 28, 2019
e8990ae
Make JsonPropertyNameAttribute.Name readonly (#37829)
maryamariyan May 28, 2019
3ca2657
Improve Debug.Assert in ConcurrentBag (#37986)
stephentoub May 28, 2019
141151b
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 28, 2019
ac24849
Remove socket cancellation workarounds on Unix from System.IO.Pipes (…
stephentoub May 28, 2019
c0629b3
Creating common security policy
blowdart May 28, 2019
7508b75
Improve SocketAddress.ToString() performance (#37973)
stephentoub May 29, 2019
2f28708
Make AuthenticateAsClient/ServerAsync cancellation token optional (#3…
stephentoub May 29, 2019
c7d48ca
Disable sporadically failing GetGCMemoryInfo test (#37995)
stephentoub May 29, 2019
c524b4d
Fix wrong Activity.Id serialization - 00 flags are used
May 29, 2019
5dc4a08
Update ProjectNTfs to beta-27729-00
dotnet-maestro-bot May 29, 2019
7c9bfaf
Update dependencies from https://github.com/dotnet/core-setup build 2…
May 28, 2019
fdfe98b
Update dependencies from https://github.com/dotnet/standard build 201…
May 28, 2019
1e67bf5
Move dotnet-tools config
ViktorHofer May 23, 2019
9956e29
Manual darc update from build '20190528.1'
ViktorHofer May 28, 2019
78aa376
React to xunit runner changes in arcade
ViktorHofer May 29, 2019
4b27d51
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 29, 2019
036e0a6
Base64 encoding with simd-support (#34529)
gfoidl May 29, 2019
4680090
Remove SSL cancellation workaround from SocketsHttpHandler (#37990)
stephentoub May 29, 2019
10afb2a
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 29, 2019
6ff8890
Merge branch 'MoveToolsConfig' of https://github.com/ViktorHofer/core…
ViktorHofer May 29, 2019
f5cf3f1
Exclude xunit.core.dll
ViktorHofer May 29, 2019
0970a99
Add package override to tools.props (#38023)
ViktorHofer May 29, 2019
e3a4eda
Avoid .ToArray() in JsonSerializer .NET Standard implementation (#37976)
adamsitnik May 29, 2019
837efeb
Re-generate System.Collections ref assembly against implementation (#…
safern May 29, 2019
c04be1e
improve reliability of HttpListenerFactory by verifying that Connect …
wfurt May 29, 2019
0bae12c
Add readonly modifiers to SequenceReader. (#37718)
JeremyKuhne May 29, 2019
1e642d1
Add test to validate #36167 is fixed. (#38029)
JeremyKuhne May 29, 2019
8ab1853
Add test to validate #37567. (#38030)
JeremyKuhne May 29, 2019
a977a24
[master] Update dependencies from dotnet/coreclr (#38020)
dotnet-maestro[bot] May 29, 2019
693be82
Merge branch 'master' into MoveToolsConfig
ViktorHofer May 29, 2019
ecfb60b
Remove some dependencies from source build (#37730)
ericstj May 29, 2019
bd492f2
Merge pull request #37900 from ViktorHofer/MoveToolsConfig
ViktorHofer May 29, 2019
c6fc43c
Enable MaxConnectionsPerServer_WaitingConnectionsAreCancelable again …
wfurt May 30, 2019
aa9db05
Update to use alpine3.9 in PRs
ViktorHofer May 29, 2019
1a60edc
Enable Microsoft.Diagnostics.Runtime to be used by tests
stephentoub May 30, 2019
a2afbff
Disable warning suppressions related to missing XML comments within (…
ahsonkhan May 30, 2019
0110344
Remove source package related comments on internal APIs and csproj/pr…
ahsonkhan May 30, 2019
e23119d
HttpCorrelationProtocol docs update: Add notice about W3C trace-conte…
May 30, 2019
f121f06
Update ProjectNTfs to beta-27730-00 (#38045)
dotnet-maestro-bot May 30, 2019
23cd3cf
Add and apply nullable attributes (dotnet/coreclr#24679)
stephentoub May 28, 2019
b2097cb
Handle nullable attributes on platforms that lack them
stephentoub May 30, 2019
75329f4
Ignore some System.Runtime tests on Mono (#37358)
EgorBo May 30, 2019
22dd87e
Add async methods in System.Data.Common, implement IAsyncDisposable
roji May 30, 2019
60d65af
Add feature detection properties to DbProviderFactory
roji May 30, 2019
fadf627
[master] Update dependencies from dotnet/standard (#38021)
dotnet-maestro[bot] May 30, 2019
7a76510
Cache the escaped property names (#37909)
steveharter May 30, 2019
99c04b1
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 30, 2019
d29c16c
Replace netstandard test projects with tfms
ViktorHofer May 27, 2019
7c51e15
Add validation target for netstandard
ViktorHofer May 30, 2019
3208640
Disable building tests on uapaot
ViktorHofer May 30, 2019
97d29c9
Harden failing EventLog.Clear test
ViktorHofer May 30, 2019
2f3d654
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 30, 2019
ed30554
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 30, 2019
adc16f3
Update float converter and related tests (#37894)
steveharter May 30, 2019
73066ea
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] May 30, 2019
0aad502
Address leftover feedback related to Skip/TrySkip APIs. (#38044)
ahsonkhan May 30, 2019
88f4967
[master] Update dependencies from dotnet/coreclr (#38057)
dotnet-maestro[bot] May 30, 2019
d24b3e3
Using reflection to add handler for user preference events (#37853)
Anipik May 30, 2019
8ce7c47
Fixing issue where assemblies would build againsta lower version of a…
joperezr May 30, 2019
02f649e
Change JsonException.Path to be a json-based path (#37938)
steveharter May 30, 2019
13ad3d0
PR feedback nits
ViktorHofer May 30, 2019
1743e47
Merge remote-tracking branch 'upstream/master' into NSTestRemoval
ViktorHofer May 30, 2019
30ca411
Merge pull request #37972 from ViktorHofer/NSTestRemoval
ViktorHofer May 30, 2019
40983e2
System.Text.Json is not inbox on netfx (#38077)
wtgodbe May 31, 2019
5a611ec
Simplify DbProviderFactory feature detection code. (#38070)
bgrainger May 31, 2019
f6b010d
Add read ahead logic for streams. (#38039)
JeremyKuhne May 31, 2019
82408cd
Add Base64 APIs to Utf8JsonReader, Utf8JsonWriter, and JsonElement (#…
ahsonkhan May 31, 2019
46ed80d
Merge pull request #38013 from lmolkova/lmolkova/fixActivityIdWorngFlags
noahfalk May 31, 2019
0d09364
Update ProjectNTfs to beta-27731-00 (#38089)
dotnet-maestro-bot May 31, 2019
655be42
using double to avoild multplication overflow (#38079)
Anipik May 31, 2019
24e256f
Disable ObjectTests.Write test (#38101)
stephentoub May 31, 2019
b07bb37
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] May 31, 2019
8b590bc
skip oledb for outerloop failures (#38090)
maryamariyan May 31, 2019
0f2fa63
Fix Loop in System.Private.Uri (#38076)
wtgodbe May 31, 2019
f8c382f
Fix IPv6Address parsing (#37734)
wtgodbe May 31, 2019
6352388
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] May 31, 2019
792eb85
[System.Text.Json]Improve error output for unsupported scenarios in S…
MarcoRossignoli May 31, 2019
39c1f79
Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods …
tannergooding May 31, 2019
fdab38c
Adding net461 target to Microsoft.Bcl.* packages (#38104)
joperezr May 31, 2019
b2fd315
Add tests for double-encoded URLs to both UrlDecode() methods (#37881)
wtgodbe May 31, 2019
e798780
Update package index and harvest props to reflect WinHttpHandler upda…
safern May 31, 2019
40f031a
Check regex timeout in loops and repetitions (#38091)
ViktorHofer May 31, 2019
a7ad25c
Add (de)serialization support for Base64 string as Byte array (#38106)
steveharter May 31, 2019
1c1b78f
Add JsonSerializer overload that takes Utf8JsonReader. (#38088)
ahsonkhan May 31, 2019
b6226a8
Merge branch 'release/3.0' into merge/master-to-release/3.0
wtgodbe May 31, 2019
8b8e1e0
Fix mutating static issue
JeremyKuhne May 31, 2019
319233f
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] May 31, 2019
e1c0b0e
[master] Update dependencies from dotnet/standard (#38100)
dotnet-maestro[bot] May 31, 2019
3090173
[master] Update dependencies from dotnet/coreclr (#38099)
dotnet-maestro[bot] May 31, 2019
6c69205
Add support for immutable dictionaries (#37710)
layomia May 31, 2019
e5577f9
Revert "Added Range Manipulation APIs to Collection<T> and Observabl…
safern May 31, 2019
de9f368
add support for 100-continue for H/2 (#36884)
wfurt May 31, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
47 changes: 31 additions & 16 deletions .azure-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,20 @@ trigger:
include:
- master
- release/3.0
paths:
exclude:
- Documentation/*
- /*.md

pr:
- master
- release/3.0
branches:
include:
- master
- release/3.0
paths:
exclude:
- Documentation/*
- /*.md

resources:
containers:
Expand All @@ -36,31 +46,36 @@ resources:
jobs:
# Windows legs
- template: /eng/pipelines/windows.yml
${{ if and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}:
parameters:
isOfficialBuild: true
parameters:
isOfficialBuild: ${{ and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}
fullMatrix: ${{ notIn(variables['Build.Reason'], 'PullRequest') }}

# Linux legs
- template: /eng/pipelines/linux.yml
${{ if and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}:
parameters:
isOfficialBuild: true
parameters:
isOfficialBuild: ${{ and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}
fullMatrix: ${{ notIn(variables['Build.Reason'], 'PullRequest') }}

# MacOS legs
- template: /eng/pipelines/macos.yml
${{ if and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}:
parameters:
isOfficialBuild: true
parameters:
isOfficialBuild: ${{ and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}
fullMatrix: ${{ notIn(variables['Build.Reason'], 'PullRequest') }}

# Only run in official builds
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}:
# Redhat6 leg is only for official builds
- template: /eng/pipelines/redhat6.yml
# RedHat6 leg
- template: /eng/pipelines/redhat6.yml
parameters:
isOfficialBuild: ${{ and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}
fullMatrix: ${{ notIn(variables['Build.Reason'], 'PullRequest') }}

# FreeBSD leg is only for official builds
# - template: /eng/pipelines/freebsd.yml
# parameters:
# isOfficialBuild: ${{ and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}
# fullMatrix: ${{ notIn(variables['Build.Reason'], 'PullRequest') }}

# Publish step
# Publish step. Only run in official builds
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notIn(variables['Build.Reason'], 'PullRequest')) }}:
- template: /eng/pipelines/publish.yml
parameters:
dependsOn:
Expand Down
18 changes: 18 additions & 0 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"version": 1,
"isRoot": true,
"tools": {
"coverlet.console": {
"version": "1.5.1",
"commands": [
"coverlet"
]
},
"dotnet-reportgenerator-globaltool": {
"version": "4.1.6",
"commands": [
"reportgenerator"
]
}
}
}
8 changes: 4 additions & 4 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
# default for csharp files.
# Note: This is only used by command line
###############################################################################
#*.cs diff=csharp
*.cs diff=csharp

###############################################################################
# Set the merge driver for project and solution files
#
# Merging from the command prompt will add diff markers to the files if there
# are conflicts (Merging from VS is not affected by the settings below, in VS
# the diff markers are never inserted). Diff markers may cause the following
# the diff markers are never inserted). Diff markers may cause the following
# file extensions to fail to load in VS. An alternative would be to treat
# these files as binary and thus will always conflict and require user
# intervention with every merge. To do so, just uncomment the entries below
Expand Down Expand Up @@ -46,9 +46,9 @@

###############################################################################
# diff behavior for common document formats
#
#
# Convert binary document formats to text before diffing them. This feature
# is only available from the command line. Turn it on by uncommenting the
# is only available from the command line. Turn it on by uncommenting the
# entries below.
###############################################################################
#*.doc diff=astextplain
Expand Down
51 changes: 9 additions & 42 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<UseSharedCompilation>true</UseSharedCompilation>

<ToolSetCommonDirectory>$(MSBuildThisFileDirectory)artifacts\toolset\Common\</ToolSetCommonDirectory>
<IsSourceProject Condition="$([System.Text.RegularExpressions.Regex]::IsMatch($(MSBuildProjectDirectory), 'src%24'))">true</IsSourceProject>
<IsSourceProject>$([System.Text.RegularExpressions.Regex]::IsMatch($(MSBuildProjectDirectory), 'src%24'))</IsSourceProject>
</PropertyGroup>

<!-- Define vNext UAP Moniker -->
Expand Down Expand Up @@ -114,25 +114,6 @@

<!-- Use msbuild path functions as that property is used in bash scripts. -->
<SourceDir>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src'))</SourceDir>

<!-- Input Directories -->
<PackagesDir>$(DotNetRestorePackagesPath)</PackagesDir>
<PackagesDir Condition="'$(PackagesDir)'=='' AND '$(NuGetPackageRoot)' != ''">$([MSBuild]::EnsureTrailingSlash('$(NuGetPackageRoot)'))</PackagesDir>
<PackagesDir Condition="'$(PackagesDir)'==''">$(RepoRoot).packages/</PackagesDir>
<!-- Respect environment variable for the .NET install directory if set; otherwise, use the current default location -->
<DotNetRoot Condition="'$(DotNetRoot)' == ''">$(DOTNET_INSTALL_DIR)</DotNetRoot>
<DotNetRoot Condition="'$(DotNetRoot)' == ''">$(RepoRoot).dotnet\</DotNetRoot>
<DotNetRoot Condition="!HasTrailingSlash('$(DotNetRoot)')">$(DotNetRoot)\</DotNetRoot>
<DotnetCliPath Condition="'$(DotnetCliPath)'==''">$(DotNetRoot)</DotnetCliPath>
<ToolHostCmd Condition="'$(ToolHostCmd)'==''">"$(DotNetRoot)dotnet"</ToolHostCmd>
<DotNetCmd>$(DotNetRoot)dotnet</DotNetCmd>
<DotNetCmd Condition="'$(OS)' == 'Windows_NT'">$(DotNetCmd).exe</DotNetCmd>
</PropertyGroup>

<!-- workaround https://github.com/dotnet/sdk/issues/2288
remove once we have a new CLI -->
<PropertyGroup>
<LanguageTargets Condition="'$(LanguageTargets)' == '' AND '$(MSBuildProjectExtension)' != '.csproj' AND '$(MSBuildProjectExtension)' != '.vbproj' AND '$(MSBuildProjectExtension)' != '.fsproj'">$(MSBuildToolsPath)\Microsoft.Common.targets</LanguageTargets>
</PropertyGroup>

<!-- Enable the analyzers for this repo -->
Expand Down Expand Up @@ -167,7 +148,8 @@
<OutputType>Library</OutputType>
<!-- Default any assembly not specifying a key to use the Open Key -->
<StrongNameKeyId>Open</StrongNameKeyId>
<RunApiCompat>true</RunApiCompat>
<RunApiCompatForSrc>$(IsSourceProject)</RunApiCompatForSrc>
<RunMatchingRefApiCompat>$(IsSourceProject)</RunMatchingRefApiCompat>
<ApiCompatExcludeAttributeList>$(RepositoryEngineeringDir)DefaultGenApiDocIds.txt</ApiCompatExcludeAttributeList>
<!-- Build as portable by default -->
<PortableBuild Condition="'$(PortableBuild)' == ''">true</PortableBuild>
Expand Down Expand Up @@ -267,7 +249,7 @@

<PropertyGroup>
<!-- Embed IBC data on release builds, if IBCMerge isn't available this will just log the commandline -->
<EnablePartialNgenOptimization Condition="'$(EnablePartialNgenOptimization)' == '' and '$(ConfigurationGroup)' == 'Release'">true</EnablePartialNgenOptimization>
<EnableNgenOptimization Condition="'$(EnableNgenOptimization)' == '' and '$(ConfigurationGroup)' == 'Release'">true</EnableNgenOptimization>

<WindowsCoreFxOptimizationDataPackageId>optimization.windows_nt-x64.IBC.CoreFx</WindowsCoreFxOptimizationDataPackageId>
<WindowsCoreFxOptimizationDataVersion>$(optimizationwindows_ntx64IBCCoreFxPackageVersion)</WindowsCoreFxOptimizationDataVersion>
Expand Down Expand Up @@ -315,9 +297,7 @@
<Features>strict</Features>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>

<!-- We cannot enable deterministic builds yet but we would like to in the future see https://github.com/dotnet/corefx/issues/2003 -->
<Deterministic>false</Deterministic>
<Deterministic>true</Deterministic>

<!-- We decided to keep this disabled by default to see some history of way have a look at https://github.com/dotnet/corefx/issues/3140 -->
<CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>
Expand All @@ -329,8 +309,8 @@
<CLSCompliant Condition="'$(CLSCompliant)'==''">true</CLSCompliant>
<GenFacadesIgnoreBuildAndRevisionMismatch>true</GenFacadesIgnoreBuildAndRevisionMismatch>

<!-- Warnings -->
<NoWarn>$(NoWarn);BCL0020</NoWarn> <!-- TODO: Remove BCL0020 once https://github.com/dotnet/arcade/pull/2158 is consumed. -->
<!-- TODO-NULLABLE: remove CS8609, CS8610 once we consume roslyn that allows nullable covariant overrides -->
<NoWarn>$(NoWarn);CS8609;CS8610</NoWarn>
</PropertyGroup>

<!-- Set up some common paths -->
Expand Down Expand Up @@ -360,8 +340,6 @@
<NetStandardRefPath>$(RefRootPath)netstandard/</NetStandardRefPath>
<NetStandard21RefPath>$(RefRootPath)netstandard2.1/</NetStandard21RefPath>
<NetFxRefPath>$(RefRootPath)netfx/</NetFxRefPath>
<!-- Keep in sync with property in eng\Tools.props. -->
<GlobalToolsDir>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', '.tools', 'globaltools'))</GlobalToolsDir>
<IbcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc'))</IbcOptimizationDataDir>
<ILAsmToolPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsToolsetDir)', 'ilasm'))</ILAsmToolPath>
<ILLinkDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsToolsetDir)', 'ILLink'))</ILLinkDir>
Expand Down Expand Up @@ -389,16 +367,13 @@

<!-- We add extra binplacing for the test shared framework until we can get hardlinking with the runtime directory working on all platforms -->
<BinPlaceTestSharedFramework Condition="'$(_bc_TargetGroup)' == 'netcoreapp' AND '$(BuildTests)'!='false'">true</BinPlaceTestSharedFramework>
<BinPlaceILCInputFolder Condition="$(_bc_TargetGroup.EndsWith('aot')) And '$(BinPlaceILCInputFolder)' == ''">true</BinPlaceILCInputFolder>
<BinPlaceUAPFramework Condition="'$(_bc_TargetGroup)' == 'uap'">true</BinPlaceUAPFramework>
<BinPlaceNETFXRuntime Condition="'$(_bc_TargetGroup)' == 'netfx'">true</BinPlaceNETFXRuntime>

<NETCoreAppTestSharedFxVersion>9.9.9</NETCoreAppTestSharedFxVersion>
<TestHostRootPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'testhost', '$(BuildConfiguration)'))</TestHostRootPath>
<NETCoreAppTestHostFxrPath>$([MSBuild]::NormalizeDirectory('$(TestHostRootPath)', 'host', 'fxr', '$(NETCoreAppTestSharedFxVersion)'))</NETCoreAppTestHostFxrPath>
<NETCoreAppTestSharedFrameworkPath>$([MSBuild]::NormalizeDirectory('$(TestHostRootPath)', 'shared', 'Microsoft.NETCore.App', '$(NETCoreAppTestSharedFxVersion)'))</NETCoreAppTestSharedFrameworkPath>
<ILCFXInputFolder>$(TestHostRootPath)ILCInputFolder</ILCFXInputFolder>
<InternalTestILCFolder>$(TestHostRootPath)TestILC</InternalTestILCFolder>

<!-- For UAP, we'll produce the layout and hard-link this into each test's directory -->
<UAPTestSharedFrameworkPath>$(TestHostRootPath)UAPLayout</UAPTestSharedFrameworkPath>
Expand All @@ -422,27 +397,18 @@
<ProjectExclusions Include="$(SourceDir)CoreFx.Private.TestUtilities/**/*.csproj" />
</ItemGroup>

<!-- Properties related to multi-file mode for ILC tests -->
<PropertyGroup Condition="'$(TargetGroup)' == 'uapaot'">
<!-- Only enable multi-file for Release-x64 and Debug-x86 for now -->
<!-- Temporarily disabling multifile test configurations. For more info, please check: https://github.com/dotnet/corefx/issues/22826
<EnableMultiFileILCTests Condition="'$(ConfigurationGroup)|$(ArchGroup)' == 'Release|x64' Or '$(ConfigurationGroup)|$(ArchGroup)' == 'Debug|x86' Or '$(ConfigurationGroup)|$(ArchGroup)' == 'Release|arm'">true</EnableMultiFileILCTests> -->
</PropertyGroup>

<!-- Specify the default constants for each target group -->
<PropertyGroup>
<DefineConstants Condition="'$(TargetGroup)' == 'uap'">$(DefineConstants),uap</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'uapaot'">$(DefineConstants),uapaot</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'netfx'">$(DefineConstants),netfx</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'netstandard'">$(DefineConstants),netstandard</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'netstandard1.0'">$(DefineConstants),NETSTANDARD10</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'netcoreapp'">$(DefineConstants),netcoreapp</DefineConstants>
<DefineConstants Condition="'$(TargetGroup)' == 'netcoreapp2.0'">$(DefineConstants),netcoreapp20</DefineConstants>
</PropertyGroup>

<PropertyGroup>
<!-- Don't run tests if we're building another platform's binaries on Windows -->
<SkipTests Condition="'$(SkipTests)' == '' and ('$(OsEnvironment)'=='Windows_NT' and '$(TargetsWindows)'!='true' and '$(OSGroup)'!='AnyOS')">true</SkipTests>

<!-- F5 and debugging support for netcoreapp and netfx inside VS. -->
<EnableLaunchSettings Condition="'$(EnableLaunchSettings)' == ''AND '$(DotNetBuildFromSource)' != 'true'">true</EnableLaunchSettings>

Expand All @@ -456,6 +422,7 @@
<GenerateFullCoverageReport Condition="'$(GenerateFullCoverageReport)' == ''">true</GenerateFullCoverageReport>
</PropertyGroup>

<Import Project="$(RepositoryEngineeringDir)references.props" />
<Import Condition="'$(IsTestProject)' == 'true' AND '$(IsTestSupportProject)' != 'true' AND '$(EnableVSTestReferences)' == 'true'" Project="$(RuntimePath)Microsoft.NET.Test.Sdk.props" />

<ItemDefinitionGroup Condition="'$(IsTestProject)' != 'true'">
Expand Down
22 changes: 2 additions & 20 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<StrongNameKeyId Condition="'$(IsTestProject)' == 'true'">$(TestStrongNameKeyId)</StrongNameKeyId>
</PropertyGroup>

<Import Project="$(RepositoryEngineeringDir)Resources.targets" />
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<PropertyGroup>
Expand Down Expand Up @@ -82,10 +83,6 @@
<BinPlaceConfiguration Condition="'$(BinPlaceTestSharedFramework)' == 'true'" Include="netcoreapp-$(_bc_OSGroup)">
<RuntimePath>$(NETCoreAppTestSharedFrameworkPath)</RuntimePath>
</BinPlaceConfiguration>
<!-- Setup the ILCInputFolder directory for testing aot -->
<BinPlaceConfiguration Condition="'$(BinPlaceILCInputFolder)' == 'true'" Include="uapaot-Windows_NT">
<RuntimePath>$(ILCFXInputFolder)</RuntimePath>
</BinPlaceConfiguration>
<!-- And the UAP folder for the F5 (CoreCLR UAP-debugging) scenario -->
<BinPlaceConfiguration Condition="'$(BinPlaceUAPFramework)' == 'true'" Include="uap-Windows_NT">
<RuntimePath>$(UAPTestSharedFrameworkPath)</RuntimePath>
Expand Down Expand Up @@ -125,30 +122,14 @@
<Import Project="$(RepositoryEngineeringDir)blockReflectionAttribute.targets" />
<Import Project="$(RepositoryEngineeringDir)codeOptimization.targets" />
<Import Project="$(RepositoryEngineeringDir)depProj.targets" Condition="'$(MSBuildProjectExtension)' == '.depproj'" />
<Import Project="$(RepositoryEngineeringDir)Resources.targets" />
<Import Project="$(RepositoryEngineeringDir)references.targets" />
<Import Project="$(RepositoryEngineeringDir)resolveContract.targets" />

<Import Project="$(ToolSetCommonDirectory)Tools.proj.nuget.g.targets" Condition="Exists('$(ToolSetCommonDirectory)Tools.proj.nuget.g.targets')" />

<!-- permit a wrapping build system to contribute targets to this build -->
<Import Condition="Exists('$(MSBuildThisFileDirectory)..\open.targets')" Project="$(MSBuildThisFileDirectory)..\open.targets" />

<Import Project="$(RepositoryEngineeringDir)referenceFromRuntime.targets" />
<Import Project="$(RepositoryEngineeringDir)illink.targets" />

<ItemGroup Condition="'$(NuGetTargetMoniker)'=='.NETStandard,Version=v1.7'">
<!-- Temporarily suppress the message until we get a nuget version that knows about the mapping between netstandard1.7 and uapvNext -->
<SuppressPackageTargetFrameworkCompatibility Include="$(UAPvNextTFM)" />
</ItemGroup>

<Target Name="ProducesPackageId"
Returns="@(PackageIds)">
<ItemGroup>
<PackageIds Include="$(Id)" />
</ItemGroup>
</Target>

<Target Name="ReportConfigurationErrorMessage"
BeforeTargets="AssignProjectConfiguration"
Condition="'$(BuildConfigurations)' != ''" >
Expand All @@ -170,6 +151,7 @@
<_GenAPICmd>$(_GenAPICmd) --out "$(_RefSourceFileOutputPath)"</_GenAPICmd>
<_GenAPICmd>$(_GenAPICmd) --exclude-attributes-list "$(_ExcludeAPIList)"</_GenAPICmd>
<_GenAPICmd>$(_GenAPICmd) --header-file "$(_LicenseHeaderTxtPath)"</_GenAPICmd>
<_GenAPICmd Condition="'$(LangVersion)' != ''">$(_GenAPICmd) --lang-version "$(LangVersion)"</_GenAPICmd>
</PropertyGroup>

<Exec Command="$(_GenAPICmd)" />
Expand Down
2 changes: 1 addition & 1 deletion Documentation/building/windows-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Building CoreFX on Windows

## Recommended Software
1. **[Visual Studio 2019 Preview](https://visualstudio.microsoft.com/vs/preview/)** (Community, Professional, Enterprise) with the latest update should be installed. The Community version is completely free.
1. **[.NET Core SDK](https://www.microsoft.com/net/download/windows)** >= v3.0.0-preview3 should be installed, which will add the `dotnet` toolchain to your path.
1. **[.NET Core SDK](https://dotnet.microsoft.com/download/dotnet-core/3.0)** >= v3.0.0-preview3 should be installed, which will add the `dotnet` toolchain to your path.

### Visual Studio 2019

Expand Down
1 change: 0 additions & 1 deletion Documentation/debugging/unix-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ It is also possible to debug .NET Core crash dumps using lldb and SOS. In order
- Matching coreclr/corefx runtime bits from the crash. To get these, you should either:
- Download the matching Jenkins archive onto your repro machine.
- Check out the coreclr and corefx repositories at the appropriate commit and re-build the necessary portions.
- You can also download the matching "symbols" nuget package from myget.org. There is a "Download Symbols" button in the myget UI for this purpose.
- lldb version 3.9. The SOS plugin (i.e. libsosplugin.so) provided is now built for lldb 3.9. In order to install lldb 3.9 just run the following commands:
```
~$ echo "deb http://llvm.org/apt/trusty/ llvm-toolchain-trusty-3.9 main" | sudo tee /etc/apt/sources.list.d/llvm.list
Expand Down
Loading