This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add support for non-generic IEnumerable, IList, ICollection#38307
Closed
layomia wants to merge 3 commits intodotnet:masterfrom
Closed
Add support for non-generic IEnumerable, IList, ICollection#38307layomia wants to merge 3 commits intodotnet:masterfrom
layomia wants to merge 3 commits intodotnet:masterfrom
Conversation
stephentoub
reviewed
Jun 7, 2019
stephentoub
reviewed
Jun 7, 2019
steveharter
reviewed
Jun 7, 2019
steveharter
reviewed
Jun 7, 2019
4fecca0 to
b7f8ca8
Compare
Contributor
Author
|
Changes here have been merged in #38319. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly addresses https://github.com/dotnet/corefx/issues/36643.
Benchmarks: dotnet/performance#547.
Json.NET
No deserialization support for
IEnumerableandICollectionHot-path perf diff
There seems to be an dependency update lag between the perf and corefx repos, so I'll run a hot-path (de)serialization perf diff later. I don't suspect there are any regressions.