This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add support for immutable array#39493
Merged
layomia merged 9 commits intodotnet:masterfrom Jul 16, 2019
Merged
Conversation
layomia
commented
Jul 15, 2019
| if (list == null) | ||
| if (list == null || | ||
| // ImmutableArray<T> is a struct, so default value won't be null. | ||
| state.Current.JsonPropertyInfo.RuntimePropertyType.FullName.StartsWith(DefaultImmutableEnumerableConverter.ImmutableArrayGenericTypeName)) |
Contributor
Author
There was a problem hiding this comment.
Is there a better way to check for this?
steveharter
approved these changes
Jul 15, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add support for ImmutableArray * Refactor immutable materializer strategies to use creator helper * Clean up + re-add tests * Check for immutable array * Correct immutable array check * Fix whitespace Commit migrated from dotnet/corefx@2811879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/38658.