[release/3.0] For Mac Catalina build, suppress warnings porting to 3.0#39984
[release/3.0] For Mac Catalina build, suppress warnings porting to 3.0#39984wtgodbe merged 2 commits intodotnet:release/3.0from
Conversation
|
@buyaa-n you will also need to fill out the template in the description: https://gist.github.com/danmosemsft/348cbe83ccd7ae0e87c5598223be1380 and get @danmosemsft's approval before merging this |
buyaa-n
changed the title
|
I'll take it Tuesday for approval |
| if (isServer != 0 && isServer != 1) | ||
| return NULL; | ||
|
|
||
| #pragma clang diagnostic push |
There was a problem hiding this comment.
Nit: please add back the whitespace that was there before, e.g. there should ideally be a blank line above this pragma
There was a problem hiding this comment.
i assume i should apply it for master first and cherry pick to this PR ...
There was a problem hiding this comment.
for such a trivial thing, you need not wait for the same change to merge into master.
There was a problem hiding this comment.
yeah, just in case commits need to be identical, but if that is not needed, will update right here
There was a problem hiding this comment.
updated here because its easier to review
| { | ||
| SSLProtocol protocol = PalSslProtocolToSslProtocol(sslProtocol); | ||
|
|
||
| #pragma clang diagnostic push |
| { | ||
| SSLProtocol protocol = PalSslProtocolToSslProtocol(sslProtocol); | ||
|
|
||
| #pragma clang diagnostic push |
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" | ||
| *pOSStatus = SSLCopyPeerTrust(sslContext, pChainOut); | ||
| #pragma clang diagnostic pop |
There was a problem hiding this comment.
Ditto. Will stop commenting on these.
|
Branch is open, merging |
7 participants
Description
Suppressing warnings for deprecated methods in macOS 10.15 (Porting from master)
Customer Impact
No impact
Regression?
No
Risk
No