Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Handle UnparseableExtension status code when building X509Chain on OSX#40063

Merged
buyaa-n merged 3 commits intodotnet:masterfrom
buyaa-n:ignore_x509_new_option
Aug 7, 2019
Merged

Handle UnparseableExtension status code when building X509Chain on OSX#40063
buyaa-n merged 3 commits intodotnet:masterfrom
buyaa-n:ignore_x509_new_option

Conversation

@buyaa-n
Copy link

@buyaa-n buyaa-n commented Aug 6, 2019

@buyaa-n buyaa-n requested review from bartonjs and krwq August 6, 2019 17:24
@buyaa-n buyaa-n added the os-mac-os-x OS-X aka Mac OS label Aug 6, 2019
@buyaa-n buyaa-n added this to the 3.0 milestone Aug 6, 2019
@buyaa-n buyaa-n requested a review from danmoseley August 6, 2019 17:26
@danmoseley
Copy link
Member

@buyaa-n if @krwq indicates this is not the corerct long term fix then we need an issue opened to track that.

@krwq
Copy link
Member

krwq commented Aug 6, 2019

I've talked with @buyaa-n offline and we will do correct fix here. Correct fix and workaround are almost the same.

Next steps:
@buyaa-n will update her PR shortly.

We will exclude @bartonjs suggestion to improve error messages on Linux/Windows (we have confirmed extra info is not currently propagated on Windows but it is on OSX without extra changes - we haven't checked linux yet). @buyaa-n will file new issue for that but we will mark that bug as 5.0 or Future since it's not exactly required for 3.0

@krwq krwq changed the title Ignoring newly introduced status as temp fix Handle UnparseableExtension status code when building X509Chain on OSX Aug 6, 2019
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit 7350b23 into dotnet:master Aug 7, 2019
@krwq
Copy link
Member

krwq commented Aug 7, 2019

@buyaa-n is there an issue for the remaining 5.0 work?

@buyaa-n
Copy link
Author

buyaa-n commented Aug 7, 2019

buyaa-n added a commit to buyaa-n/corefx that referenced this pull request Aug 7, 2019
…OSX (dotnet#40063)

Setting related error flag for newly introduced error status
@karelz karelz modified the milestones: 3.0, 5.0 Aug 9, 2019
@buyaa-n buyaa-n deleted the ignore_x509_new_option branch November 1, 2019 20:57
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…OSX (dotnet/corefx#40063)

Setting related error flag for newly introduced error status


Commit migrated from dotnet/corefx@7350b23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac Catalina compatibility: System.Security.Cryptography.X509Certificates.Tests crashing

4 participants