This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
danmoseley
approved these changes
Aug 6, 2019
Member
|
@krwq if build is totally failing you do not need to wait for CI, especially if it's a trivial fix. |
Member
Author
|
@dotnet/dnceng any clues why the original PR (#39572) is green while PRs using that change are red? |
Member
|
@krwq: it was old results: Another reason for us to keep our PR list short 😺 |
Member
Author
|
missed that 😄 |
Member
|
Thanks. |
Contributor
|
Thank you! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@0cb3c13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems #39572 has forgotten to remove unused field which is causing build to fail. Interestingly this didn't fail on that PR.