This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] pal_console: add missing mutex_unlock (#40160)#40191
Merged
danmoseley merged 1 commit intodotnet:release/3.0from Aug 9, 2019
Merged
[release/3.0] pal_console: add missing mutex_unlock (#40160)#40191danmoseley merged 1 commit intodotnet:release/3.0from
danmoseley merged 1 commit intodotnet:release/3.0from
Conversation
danmoseley
approved these changes
Aug 9, 2019
Member
|
tactics approved, merge when green |
Member
|
Thank you @stephentoub |
tmds
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #40160 to release/3.0.
Fixes https://github.com/dotnet/corefx/issues/40137
cc: @danmosemsft, @tmds
Description
Processes on Unix end up sharing a terminal. We have a heuristic which assumes that if a parent process is interacting with the terminal, any child processes it launches won't. As such, when we do Process.Start on Unix, we check if the parent process is currently doing a read (e.g. Console.ReadLine()), and if it is, we avoid doing some configuration of the terminal as part of launching the child. That check is performed under a lock, and we neglect to release that lock when we find it's doing a read.
Customer Impact
Certain patterns would simply hang forever, trying to take a lock that will never be released.
Regression?
Yes, introduced in 3.0 as part of #35621.
Risk
Minimal. It's obvious from a scoped code review that the previous code was wrong.