Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Initial commit of tests for System.Collections.NonGeneric#407

Merged
joshfree merged 1 commit into
dotnet:masterfrom
joshfree:master
Jan 13, 2015
Merged

Initial commit of tests for System.Collections.NonGeneric#407
joshfree merged 1 commit into
dotnet:masterfrom
joshfree:master

Conversation

@joshfree
Copy link
Copy Markdown
Member

@joshfree joshfree commented Jan 13, 2015

Porting legacy tests for system.collections.nongeneric to git

arraylist, sortedlist, and hashtable tests to come in a 2nd commit

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jan 13, 2015

Hi @joshfree, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@joshfree joshfree self-assigned this Jan 13, 2015
@FiveTimesTheFun
Copy link
Copy Markdown
Contributor

FiveTimesTheFun commented Jan 13, 2015

Thanks @joshfree - I believe you were going to push a followup commit, I'll look for that.

@joshfree
Copy link
Copy Markdown
Member Author

joshfree commented Jan 13, 2015

test this please

akoeplinger
akoeplinger reviewed Jan 13, 2015
View reviewed changes
Comment thread ...ystem.Collections.NonGeneric/tests/ReadOnlyCollectionBase/ReadOnlyCollectionBaseTests.csproj Outdated
Copy link
Copy Markdown
Member

@akoeplinger akoeplinger Jan 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToolsVersion should be 12.0

@joshfree
Copy link
Copy Markdown
Member Author

joshfree commented Jan 13, 2015

sigh. Jenkins crapped out.

18:44:39 FATAL: java.io.IOException: Connection aborted: org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport@a4e966[name=Azure0112023939]
18:44:39 hudson.remoting.RequestAbortedException: java.io.IOException: Connection aborted: org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport@a4e966[name=Azure0112023939]
18:44:39 at hudson.remoting.Request.abort(Request.java:295)

test this please

@joshfree
Copy link
Copy Markdown
Member Author

joshfree commented Jan 13, 2015

test this please

1 similar comment
@FiveTimesTheFun
Copy link
Copy Markdown
Contributor

FiveTimesTheFun commented Jan 13, 2015

test this please

@krwq
Copy link
Copy Markdown
Member

krwq commented Jan 13, 2015

Looks good if CI doesn't complain 👍

joshfree added a commit that referenced this pull request Jan 13, 2015
@joshfree
Merge pull request #407 from joshfree/master
f2dee12 
Initial commit of tests for System.Collections.NonGeneric
@joshfree joshfree merged commit f2dee12 into dotnet:master Jan 13, 2015
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
@AlekseyTs AlekseyTs mentioned this pull request Jan 31, 2020
Closed
aik-jahoda pushed a commit to aik-jahoda/corefx that referenced this pull request Mar 25, 2021
Added supressions. (dotnet#407)
c854782
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@joshfree joshfree

Labels

None yet

Projects

None yet

Milestone

1.0.0-rtm

Development

Successfully merging this pull request may close these issues.

7 participants

@joshfree @dnfclas @FiveTimesTheFun @krwq @akoeplinger @karelz @dotnet-bot