This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mirror changes from dotnet/coreclr#42547
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 12, 2019
Merged
Conversation
* Method Add(ref BigInteger lhs, uint value, ref BigInteger result) would store most of the result blocks into lhs instead of result. * Method ShiftLeft(ulong input, uint shift, ref BigInteger output) with a shift argument exceeding 32 would generally compute the higher blocks incorrectly. * Multiply(ref BigInteger lhs, uint value, ref BigInteger result) would not set result._length in some cases. * IsZero() would incorrectly return false for non-canonical zeros with _length > 0. Fix: * Inline Add(ref BigInteger, uint, ref BigInteger) into Add(uint). * Inline ShiftLeft(ulong, uint, ref BigInteger) into Pow2. * Inline ExtendBlock and ExtendBlocks into Pow2. * Properly handle 0 in SetUInt32 and SetUInt64. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
|
@davidsh any reason why you triggered an outerloop run here? |
Contributor
I was following up on the build break introduced by PR #42522 and resolved by PR #42548. I noticed that #42547 had failed due to the build break. After PR #42548 was merged, I just re-ran CI. I always do "/azp run" since it runs both inner and outer loops. It's a habit since we always run both for networking. |
Member
|
I would avoid doing that as Outerloop never really succeeds which blocks the auto merges of such PRs. Ie when you apply the auto merge label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from dotnet/coreclr
Please REBASE this PR when merging
cc @ts2do