This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update CoreLib path for consolidation#42577
Merged
ViktorHofer merged 1 commit intodotnet:masterfrom Nov 13, 2019
Merged
Conversation
ViktorHofer
commented
Nov 13, 2019
ViktorHofer
force-pushed
the
CoreLibPath
branch
from
7a84cad to
772d91f
Compare
safern
reviewed
Nov 13, 2019
| </Compile> | ||
| <Compile Include="$(CommonPath)\CoreLib\Interop\Unix\System.Native\Interop.PathConf.cs"> | ||
| <Compile Include="$(CoreLibDir)Interop\Unix\System.Native\Interop.PathConf.cs"> | ||
| <Link>Common\Interop\Unix\Interop.PathConf.cs</Link> |
Member
There was a problem hiding this comment.
It seems like this Link didn't contain CoreLib so it still contains the Common prefix.
safern
reviewed
Nov 13, 2019
| </Compile> | ||
| <Compile Include="$(CommonPath)\CoreLib\Interop\Unix\System.Native\Interop.MountPoints.cs"> | ||
| <Compile Include="$(CoreLibDir)Interop\Unix\System.Native\Interop.MountPoints.cs"> | ||
| <Link>Common\Interop\Unix\Interop.MountPoints.cs</Link> |
safern
reviewed
Nov 13, 2019
| </Compile> | ||
| <Compile Include="$(CommonPath)\CoreLib\Interop\Windows\Kernel32\Interop.CloseHandle.cs"> | ||
| <Compile Include="$(CoreLibDir)Interop\Windows\Kernel32\Interop.CloseHandle.cs"> | ||
| <Link>Common\Interop\Windows\Interop.CloseHandle.cs</Link> |
safern
reviewed
Nov 13, 2019
| </Compile> | ||
| <Compile Include="$(CommonPath)\CoreLib\Interop\Unix\System.Native\Interop.Read.cs"> | ||
| <Compile Include="$(CoreLibDir)Interop\Unix\System.Native\Interop.Read.cs"> | ||
| <Link>Common\Interop\Unix\libc\Interop.Read.cs</Link> |
Member
There was a problem hiding this comment.
Ditto. I guess we don't want to fix these? There are many like this, seem to be out of the scope of this PR?
safern
approved these changes
Nov 13, 2019
Member
Author
|
Yes that's out of scope. |
Member
|
Looks good to me. I might have chosen a name more like CoreLibSharedDir, but you've merged, and it's not a big deal. |
macrogreg
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Sep 24, 2020
Commit migrated from dotnet/corefx@dc6136f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search&Replace update of the CoreLib sources from$(CommonPath)\CoreLib\ to $ (CoreLibDir). $(CoreLibDir) detects automatically adapts to the runtime repo and changes paths accordingly.