This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Port SafeProcessHandle.Unix: fix missing DangerousRelease#42941
Merged
Anipik merged 1 commit intodotnet:release/3.1from Jul 14, 2020
Merged
Conversation
stephentoub
approved these changes
Jun 29, 2020
danmoseley
changed the title
danmoseley
added
area-System.Diagnostics.Process
and removed
Servicing-consider
Anipik
approved these changes
Jul 14, 2020
Anipik
added
the
* NO MERGE *
Anipik
removed
the
* NO MERGE *
freddyrios
added a commit
to copenhagenatomics/CA_DataUploader
that referenced
this pull request
Feb 17, 2021
reason: the root cause of the last rpi temp slow downs / crashes, is a leak on dotnet core. i.e. specifically we want this fix dotnet/runtime#37446 we could have gone with .net core 3.1.7, but we were already planning to move to .net 5 anyway dotnet/corefx#42941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port dotnet/runtime#37412
Description
Ports #37412. Original issue dotnet/runtime#36661
Fixes regression introduced in this PR between 2.2 and 3.0
Description from original PR
Because the SafeProcessHandle was not owned, ReleaseHandle was not called, causing the wrapped SafeWaitHandle to never release its resources.
Customer Impact
From customer:
We are asked to port this to enable the customer to migrate to 3.1.
Risk
Low.