This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Fix build clang10#43130
Closed
ayakael wants to merge 1 commit into
Closed
Conversation
Author
|
@omajid This bug is also in Fedora's 3.1 package. Is there a reason you did not upstream? I see if breaks checks in Windows / MacOS build, thus I want to see if its worth keeping open. |
Member
|
I think it's a good idea to keep corefx (and coreclr) building with newer clang versions. I have a PR in progress for clang 13 support as well. But we can't break Windows or macOS. Perhaps we can check that the compiler supports the flags before enabling them? |
ayakael
force-pushed
the
alpine/fix-build-clang10
branch
from
afc59bf to
f81be2c
Compare
Author
|
Referencing your PR, I've introduced the checks. Thanks! |
|
@hoyosjs is this something you could help review? |
Member
|
/azp run corefx-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Don't see how, but there's a fair amount of failures here. |
|
Closing since 3.1 is going out of support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build with clang 10+. I'm not sure how this affects previous versions of clang, I havn't had the opportunity to test.
Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695