This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enabling Globalization tests that currently pass on Unix.#4747
Merged
Conversation
Member
There was a problem hiding this comment.
This test appears to be failing on Windows:
System.Globalization.Tests.CompareInfoCompare.Test160 [FAIL]
Assert.Equal() Failure
Expected: 1
Actual: -1
Stack Trace:
d:\j\workspace\dotnet_corefx_windows_release_prtest\src\System.Globalization\tests\CompareInfo\CompareInfoCompare.cs(534,0): at System.Globalization.Tests.CompareInfoCompare.Test(CultureInfo culture, String str1, String str2, Int32 expected, CompareOptions options)
d:\j\workspace\dotnet_corefx_windows_release_prtest\src\System.Globalization\tests\CompareInfo\CompareInfoCompare.cs(526,0): at System.Globalization.Tests.CompareInfoCompare.Test160()
This shouldn't depend on your coreclr changes, right?
Member
Author
There was a problem hiding this comment.
Yes, this was a bad assumption on my part. It is fixed in the commit I pushed yesterday.
I had the wrong sorting direction for halfwidth and fullwidth characters in our ICU collation rules. I've changed the product code to match Windows, and updated the test.
Member
|
LGTM |
Member
Author
|
@ellismg @steveharter - Here are the tests I enabled/fixed with dotnet/coreclr#2196 |
eerhardt
force-pushed
the
CompareOptions
branch
from
8baa65e to
c584263
Compare
Member
Author
|
@dotnet-bot test this please |
…on is implemented on Unix. I also added a few more test cases.
eerhardt
force-pushed
the
CompareOptions
branch
from
c584263 to
f92e75a
Compare
eerhardt
added a commit
that referenced
this pull request
Dec 13, 2015
Enabling Globalization tests that currently pass on Unix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After dotnet/coreclr#2196 is merged, these tests will now be passing. This can't be merged until the corresponding coreclr PR is merged.
Note: I changed 1 set of tests for the following reasoning:
I removed the "unassigned" unicode character in the tests because the tests directly above them were already testing for "unassigned" unicode characters and ICU behavior differs from Windows behavior - Windows ignores unassigned characters, ICU doesn't.
@ellismg @stephentoub @tarekgh
I'm not sure I fixed all these tests with my current PR, but I went through all ActiveIssue #846 tests and enabled any test that passed on my machine.