This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Have IList and non-IList versions of all Enumerable.Skip tests.#5280
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jan 10, 2016
Merged
Have IList and non-IList versions of all Enumerable.Skip tests.#5280stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
dotnet#4551 introduced optimised versions of Skip for IList<T> sources. Have all tests for Skip test both this and the previous path.
Contributor
Author
|
@stephentoub this is to address the concerns you raised at #4551 (comment) |
Member
|
@dotnet-bot test this please |
Member
|
LGTM. Thanks, @JonHanna. |
Member
|
Test Innerloop Windows_NT Debug Build and Test please |
Member
|
Test Innerloop Windows_NT Release Build and Test please |
Member
|
Test Innerloop Windows_NT Debug Build and Test please |
Member
|
Test Innerloop Windows_NT Release Build and Test please |
stephentoub
added a commit
that referenced
this pull request
Jan 10, 2016
Have IList and non-IList versions of all Enumerable.Skip tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4551 introduced optimised versions of Skip for IList sources. Have all
tests for Skip test both this and the previous path.