SslStream WriteAsync#5505
Conversation
|
cc: @CIPop @stephentoub |
|
Actually ReadAsync doesn't look too bad, other than the effects of async all the way down... |
There was a problem hiding this comment.
I'd rather move these validations out of async scope.
There was a problem hiding this comment.
Done. Also have moved it up for sync so they remain matching implementations
Also have done it for sync so they remain matching implementations
benaadams
force-pushed
the
sslstream-async
branch
from
d7e8c19 to
52d2b98
Compare
|
Going through Read in more detail; which really is more complicated, and since its the security stream I don't think its advisable for me to try to convert it. So will just leave my contribution as the WriteAsync portion and bow out... |
|
Thanks @benaadams. Please add tests to validate the new behaviors. |
@benaadams Given the code complexity of the original .Net Desktop code, I'd rather retry to port the code from _SslStream.cs instead of creating new TPL APIs (i.e. merging this PR). After the Begin/End APIs are implemented, we can add TPL overrides to Read/WriteAsync based on wrappers similar to the ones in NetworkStream and NegotiateStream. |
|
@CIPop I'm good with that |
6 participants
This is just the WriteAsync portion of https://github.com/dotnet/corefx/issues/5077
The ReadAsync looks a lot more complicated so I'm not even going to attempt (i.e. the Read wasn't immediately apparent to me)