This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Two Stream.Read/WriteAsync improvements#5534
Merged
Merged
Conversation
A logical port of two of the three fixes in dotnet/coreclr#2724. Makes it so that Read/WriteAsync calls are serialized asynchronously rather than synchronously, and so that Wait()'ing on a Read/WriteAsync task may be able to inline the execution onto the current thread. This also reduces allocations when calling Read/WriteAsync (though there are still more optimizations that could be done).
Member
|
LGTM |
Member
Author
|
@dotnet-bot test this please |
stephentoub
added a commit
that referenced
this pull request
Jan 20, 2016
Two Stream.Read/WriteAsync improvements
5 tasks
5 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…_corefx Two Stream.Read/WriteAsync improvements Commit migrated from dotnet/corefx@fb4c5ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A logical port of two of the three fixes in dotnet/coreclr#2724 (the third to avoid Begin/End isn't relevant here, as the BeginEnd methods don't exist). Makes it so that Read/WriteAsync calls are serialized asynchronously rather than synchronously, and so that Wait()'ing on a Read/WriteAsync task may be able to inline the execution onto the current thread. This also reduces allocations when calling Read/WriteAsync (though there are still more optimizations that could be done).
cc: @jkotas, @AlfredoMS, @ericstj