Implementing NegoState.Unix.cs#5726
Conversation
|
cc: @joshfree for tracking #2483 Pre-requisite for merging this PR is #5500 and #5581. Please ignore the 1st 3 commits which are from #5581. We are trying to get early feedback on the xplat implementation without gating on merge of the those PRs. Note that Unix build is expected to fail since the .csproj includes files that are a part of #5500. |
|
cc: @CIPop |
|
There really need to be automated tests for this. At minimum for the golden path. And they need to be enabled before the code gets merged. PlatformNotSupportedException is (to me) better than it being horribly broken... and even if it works in this set of commits there's nothing to say that the next one won't break it, unless there's a test. |
2 reasons for this:
|
Agreed. Had a few offline discussions regarding this. We are going to move the development to a private branch. We expect to merge test code there once we finalize the test strategy. And to ensure master is never broken, the contract is that we can merge from the private branch only after sufficient automated test coverage is there. |
Sorry.. that should read "SafeFreeNegoCredentials" |
|
moved this to #5773 in dev/NegotiateStream branch . |
It includes the implementation on NegoState.Unix pal on top of the common refactoring changes( #5581)
Please refer to the Commit 4 of this PR for reviewing.
Includes:
Implementation of NegoState.Unix.cs Methods.
Implementaion of SafeHandles to be used.
Tested locally as Linux client with windows server.
cc: @stephentoub , @bartonjs @vijaykota