This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Native shims for libheimntlm#5728
Closed
kapilash wants to merge 2 commits into
Closed
Conversation
Introducing native shims for libheimntlm inorder to support NTLM
Contributor
Author
Contributor
|
cc: @joshfree for tracking #2483 |
Member
|
Needs a package under src/Native/pkg. /cc @chcosta |
Member
|
@dotnet-bot test CI please |
Member
There was a problem hiding this comment.
This URL is for explaining something to do with NTLM. I don't understand why it's in a method for hashing.
Member
|
cc: @ericeil |
Contributor
|
Added a label to prevent accidental merge while we are moving this to dev/negotiatestream |
Use IncrementalHash instead of implementing it Use Names consistent with the other PR Conflicts: src/Common/src/Interop/Linux/System.Net.Security.Native/Interop.Ntlm.cs
Member
There was a problem hiding this comment.
Should this be moved to inside of the using so that the SafeNtlmBufferHandle is disposed even if the operation fails? Or is data guaranteed to be null in the event of a failure? (If it's not-null but IsInvalid, we should still dispose of it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing native shims for libheimntlm inorder to support NTLM