This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove unused paths in Set.#5778
Merged
VSadov merged 2 commits intodotnet:masterfrom Jan 29, 2016
Merged
Conversation
IntersectQueryOperator does a call to Contains followed by a call to Remove on the same set for the same value. Since Remove takes a very similar path to Contains in checking for existance, and returns false when the item to remove isn't found, this can be simplified to just Remove. Also remove unused constructor on Set.
Set in Linq and Linq.Parallel never has Add called after Remove. Remove paths and fields only necessary in that case. Add debug-only check on this assumption, so any new uses that break this assumption are flagged to the developer.
Member
|
cc: @VSadov, @AlfredoMS LGTM |
Member
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Remove unused paths in Set. Commit migrated from dotnet/corefx@51489e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set in Linq and Linq.Parallel never has
Add()called afterRemove(). Remove paths and fields only necessary in that case.Add debug-only check on this assumption, so any new uses that break this assumption are flagged to the developer.
IntersectQueryOperatordoes a call toContains()followed by a call toRemove()on the same set for the same value. SinceRemove()takes a very similar path toContains()in checking for existance, and returns false when the item to remove isn't found, this can be simplified to justRemove().Also remove unused constructor on
Set.This will allow for further improvements to
Enumerable.Distinct()andEnumerable.Union()in conjunction with #5777.