This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Disable SSLv2 and SSLv3 in CurlHandler#6672
Merged
stephentoub merged 2 commits intodotnet:masterfrom Mar 5, 2016
Merged
Conversation
Contributor
|
👏 That made my day |
|
|
||
| internal static void SetSslOptions(EasyRequest easy, ClientCertificateOption clientCertOption) | ||
| { | ||
| easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSLVERSION, (long)Interop.Http.CurlSslVersion.CURL_SSLVERSION_TLSv1); // disable SSLv2/SSLv3 |
Member
There was a problem hiding this comment.
I went to look this up in the documentation to confirm that this wasn't going to lock it to 1.0.
Might be worth a comment that says that this value enables all TLS 1.x versions and disables SSLv2 and SSLv3.
Contributor
There was a problem hiding this comment.
I went to look this up in the documentation to confirm that this wasn't going to lock it to 1.0.
I had the same thought.
Member
Author
There was a problem hiding this comment.
Tweaked the comment that was there.
Member
|
LGTM, aside from maybe adding one comment. (Oh, no, what about the 0.01% (1/10000) of sites that still use SSLv3? There, pretended to defend them.) |
Contributor
|
👍 |
Contributor
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Mar 5, 2016
Disable SSLv2 and SSLv3 in CurlHandler
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Disable SSLv2 and SSLv3 in CurlHandler Commit migrated from dotnet/corefx@27d02a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forces CurlHandler to not use SSLv2 or SSLv3 even if they're available. SSLv2 has been disabled by default in libcurl since 7.18.1, and SSLv3 since 7.39.0, but this ensures they're disabled even before those versions.
Fixes https://github.com/dotnet/corefx/issues/6668
cc: @bartonjs, @CIPop, @davidsh, @kapilash, @joelverhagen