This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Compile and pack System.Runtime.Extensions as netstandard13aot#6779
Merged
Conversation
Member
Author
|
@ericstj @weshaggard could you please have a look? |
Member
Author
|
hold on, I am seeing some dependencies checking errors. I'll take a look and update the changes |
The purpose of the change is to have aot flavor which not depending on WinRT and to be consumed by corert. Note that as System.Runtime.Extensions depends on System.Private.Uri, we also did the change to have System.Private.Uri support netstandard13aot too
tarekgh
force-pushed
the
morecorertsupport
branch
from
2350609 to
d55d6ec
Compare
Member
Author
|
@ericstj @weshaggard now everything looks fine. please have a look when you have a chance. Thanks. |
Member
Author
|
@ericstj @weshaggard please have a quick look |
Member
|
LGTM |
weshaggard
added a commit
that referenced
this pull request
Mar 11, 2016
Compile and pack System.Runtime.Extensions as netstandard13aot
Merged
| char [] chars = new char[length]; | ||
| pBytes = (byte *) ptr; | ||
|
|
||
| for (int i=0; i<length; i++) |
Member
There was a problem hiding this comment.
This should use UTF8 encoding instead. Adding it to the issue #6778
sergiy-k
added a commit
to sergiy-k/coreclr
that referenced
this pull request
Mar 12, 2016
…mblies Change dotnet/corefx#6779 in CoreFx added corert assemblies to the mix of assemblies that are built for CoreCLR on Unix which broke the logic in runtest.sh that creates an overlay for running tests. This change creates a work around for the problem.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Compile and pack System.Runtime.Extensions as netstandard13aot Commit migrated from dotnet/corefx@7fe3e07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the change is to have aot flavor which not depending on WinRT and
to be consumed by corert.
Note that as System.Runtime.Extensions depends on System.Private.Uri, we also
did the change to have System.Private.Uri support netstandard13aot too