Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix globalization tests to make it work on Windows 7#7139

Merged
tarekgh merged 1 commit intodotnet:masterfrom
tarekgh:FixWin7GlobalizationTests
Mar 22, 2016
Merged

Fix globalization tests to make it work on Windows 7#7139
tarekgh merged 1 commit intodotnet:masterfrom
tarekgh:FixWin7GlobalizationTests

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 22, 2016

No description provided.

@tarekgh
Copy link
Member Author

tarekgh commented Mar 22, 2016

FYI @joshfree

public static bool IsWindows7 { get; } = IsWindows && GetWindowsVersion() == 6 && GetWindowsMinorVersion() == 1;
public static int WindowsVersion { get; } = GetWindowsVersion();

private static int GetWindowsVersion()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Priya91

@joshfree
Copy link
Member

Thanks @tarekgh. LGTM overall

tarekgh added a commit that referenced this pull request Mar 22, 2016
Fix globalization tests to make it work on Windows 7
@tarekgh tarekgh merged commit 2c09b30 into dotnet:master Mar 22, 2016
@tarekgh tarekgh deleted the FixWin7GlobalizationTests branch November 16, 2016 17:57
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…onTests

Fix globalization tests to make it work on Windows 7

Commit migrated from dotnet/corefx@2c09b30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants