Conversation
|
We want to keep divided the idea of building and running the tests so I added a property called BuildTests. |
build-tests.cmd
Outdated
| @@ -0,0 +1,24 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
Make this toggleable like we now do in build.cmd
@if "%_echo%" neq "on" echo off
|
A few minor notes, but nothing blocking. LGTM |
build.proj
Outdated
| <FilterToOSGroup Condition="'$(_OriginalOSGroup)' == ''">$(OSEnvironment)</FilterToOSGroup> | ||
| </Project> | ||
| <Project Include="src\tests.builds" Condition="$(BuildTests)=='true'"> | ||
| <FilterToOSGroup Condition="'$(_OriginalOSGroup)' == ''">$(OSEnvironment)</FilterToOSGroup> |
There was a problem hiding this comment.
This seems unnecessary with your changes in tests.builds itself.
|
FYI @sokket |
|
What about a build-tests.sh script? |
|
@sokket I want to address all the feedback here and once approved implement build-tests.sh |
|
@maririos Would that come in tomorrow then? I'm just concerned about having different ways of building and running tests on each platform (locally) when we don't have that today |
|
@sokket There are not going to be differences on how we build/run the tests as the DW scripts are not changing the way we work by default today. Once we have the different steps of the DW implemented then we are going to enable it. |
|
@weshaggard After some tests and talking to @dsgouda perf testing was not broken by my change, but for consistency I moved PerfTesting.targets to build.proj |
Build tests as a separate task of build.cmd with a build-tests.cmd script. When we run build.cmd passing /p:BuildTests=false the tests are not build. Note: the property Skiptests=true only disables the execution of the tests. Commit migrated from dotnet/corefx@814247f
8 participants
Build tests as a separate task of build.cmd with a build-tests.cmd script.
When we build passing /p:SkipTests=true the tests are built but not executed. With this change, /p:SkipTests=true allows us to not build nor execute the tests.
cc: @weshaggard @naamunds @chcosta