Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update buildtools.#7255

Merged
Priya91 merged 1 commit intodotnet:masterfrom
Priya91:buildtools2
Mar 28, 2016
Merged

Update buildtools.#7255
Priya91 merged 1 commit intodotnet:masterfrom
Priya91:buildtools2

Conversation

@Priya91
Copy link
Contributor

@Priya91 Priya91 commented Mar 25, 2016

Contains changes for native shim local copy.

cc @stephentoub @weshaggard
#7081

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 25, 2016

@dotnet-bot Test outerloop osx debug

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 25, 2016

@dotnet-bot Test outerloop Ubuntu14.10 debug

@stephentoub
Copy link
Member

stephentoub commented Mar 25, 2016

Is that the new format for build tools numbering? If so, LGTM.

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 25, 2016

@stephentoub Yeah..

@weshaggard weshaggard mentioned this pull request Mar 25, 2016
Merged
@Priya91
Copy link
Contributor Author

Priya91 commented Mar 25, 2016

@dotnet-bot Test outerloop Ubuntu14.04 debug

@stephentoub
Copy link
Member

stephentoub commented Mar 26, 2016

Thanks, @Priya91. Looks like this addressed the shims issue. A few tests failed on Ubuntu, but they're all known issues unrelated to your change.

@stephentoub
Copy link
Member

stephentoub commented Mar 26, 2016

The OSX tests appear to be hanging in the NetworkInformation tests. Same thing happened the first time the outerloop OSX tests ran... hung in what appears to be the same place.

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 27, 2016

The OSX tests appear to be hanging in the NetworkInformation tests. Same thing happened the first time the outerloop OSX tests ran... hung in what appears to be the same place.

This does not repro locally on Mac OSX. Retriggering the run again.

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 27, 2016

@dotnet-bot Test outerloop OSX debug

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 28, 2016

Outerloop OSX passed. Merging.

@Priya91 Priya91 merged commit a5f1cb5 into dotnet:master Mar 28, 2016
@Priya91 Priya91 deleted the buildtools2 branch March 28, 2016 00:02
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@Priya91
Merge pull request dotnet/corefx#7255 from Priya91/buildtools2
7c48411 
Update buildtools.

Commit migrated from dotnet/corefx@a5f1cb5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rtm

Development

Successfully merging this pull request may close these issues.

4 participants

@Priya91 @stephentoub @karelz @dnfclas