Fixes to the dev workflow scripts for OSX#7257
Conversation
|
FYI @jhendrixMSFT |
|
|
||
| if [ "$sync_src" == true ]; then | ||
| echo "Fetching git database from remote repos..." | ||
| git fetch --all -p -v &>> $sync_log |
There was a problem hiding this comment.
I'm not sure what the & was doing there to begin with, did you test if this works on Ubuntu?
There was a problem hiding this comment.
Me neither.
Yes, I tested it in Ubuntu and OS X
@naamunds why do we have & there?
There was a problem hiding this comment.
@joperezr @maririos The & was there to redirect both stderr and stdout to the file. Most of the output from git fetch comes from stderr, so it's not sufficient to just redirect stdout to the file. This documentation has more info about I/O redirection in Bash.
According to that guide, the &> was added in Bash 4, so that would explain the issue running it on OS X, where Bash 2 is still used by default, I think. I had to make a fix for that reason in fe6ac97.
It looks like a workaround is to use >>filename 2>&1; I'll test that and then send out a PR if it works.
|
Other than that small comment and assuming that this is tested in Ubuntu and OSX it LGTM |
| Darwin) | ||
| OS=OSX | ||
| __DOTNET_PKG=dotnet-osx-x64 | ||
| ulimit -n 2048 |
There was a problem hiding this comment.
Note that this is only going to apply to the current session.
There was a problem hiding this comment.
Does that mean that if this script calls in to another sh script, that one won't have this setting? If so then we need to apply this in the init-tools in buildtools as well.
Fixes to the dev workflow scripts for OSX Commit migrated from dotnet/corefx@26e83ae
8 participants
sync.sh was not marked as executable and had a syntax error.
cc: @naamunds @weshaggard @joperezr