This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
Member
There was a problem hiding this comment.
I don't believe this is meant to be the name of the member... it's simply a comment saying that this should be unreachable.
Contributor
Author
|
@stephentoub PR feedback has been addressed. |
Member
|
LGTM @davidsh, any concerns with the networking changes? |
Member
|
Test Innerloop Ubuntu Release Build and Test please |
Contributor
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Use nameof in Common Commit migrated from dotnet/corefx@38b3aeb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #7290 by replacing some of the magic strings in
Commonwithnameof.cc @stephentoub