Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove "UnsupportedPlatforms" metadata#7508

Closed
ellismg wants to merge 3 commits intodotnet:masterfrom
ellismg:run-tests
Closed

Remove "UnsupportedPlatforms" metadata#7508
ellismg wants to merge 3 commits intodotnet:masterfrom
ellismg:run-tests

Conversation

@ellismg
Copy link
Contributor

@ellismg ellismg commented Apr 5, 2016

Since #6572 was merged, we only build test projects for the platforms
they test. This means the UnsupportedPlatforms metadata is no longer
needed (instead using the .builds file to control when the project is
built is the right thing to do).

Leverage this in run-test.sh, we now simply loop over all the tests in
the relevent folders under bin/tests, depending on the platform in
question.

ellismg added 3 commits April 4, 2016 15:54
Since dotnet#6572 was merged, we only build test projects for the platforms
they test.  This means the UnsupportedPlatforms metadata is no longer
needed (instead using the .builds file to control when the project is
built is the right thing to do).

Leverage this in run-test.sh, we now simply loop over all the tests in
the relevent folders under bin/tests, depending on the platform in
question.
@ellismg
Copy link
Contributor Author

ellismg commented Apr 5, 2016

/cc @sokket @weshaggard
FYI @Chrisboh

@weshaggard
Copy link
Member

cc FYI @Priya91 @joperezr

@weshaggard
Copy link
Member

LGTM

For the cases were you removed them from the csproj files could you please have a look at the associated builds file to make sure the filtering looks correct.

@ellismg
Copy link
Contributor Author

ellismg commented Apr 5, 2016

I'm going to add some code to run-test.sh to handle the case where an path is passed to corefx-tests that is a platform specific test folder (like CI does) instead of the root of the test folder (which is what we want going forward).

After this lands, I'll update the build definitions.

@Priya91
Copy link
Contributor

Priya91 commented Apr 5, 2016

LGTM

@Priya91
Copy link
Contributor

Priya91 commented Apr 5, 2016

@ellismg Doesn't the netci.groovy have to be updated? It has this now,

--corefx-tests \${WORKSPACE}/bin/tests/${osGroup}.AnyCPU.${configurationGroup} \\

@Chrisboh
Copy link
Member

Chrisboh commented Apr 5, 2016

LGTM

@ellismg
Copy link
Contributor Author

ellismg commented Apr 5, 2016

@ellismg Doesn't the netci.groovy have to be updated?

Yes. I'm fixing the script locally to work with and without the changes to netci.groovy and I will update netci.groovy as well.

@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants