This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove "UnsupportedPlatforms" metadata#7508
Closed
ellismg wants to merge 3 commits intodotnet:masterfrom
Closed
Conversation
Since dotnet#6572 was merged, we only build test projects for the platforms they test. This means the UnsupportedPlatforms metadata is no longer needed (instead using the .builds file to control when the project is built is the right thing to do). Leverage this in run-test.sh, we now simply loop over all the tests in the relevent folders under bin/tests, depending on the platform in question.
Contributor
Author
|
/cc @sokket @weshaggard |
Member
Member
|
LGTM For the cases were you removed them from the csproj files could you please have a look at the associated builds file to make sure the filtering looks correct. |
Contributor
Author
|
I'm going to add some code to run-test.sh to handle the case where an path is passed to corefx-tests that is a platform specific test folder (like CI does) instead of the root of the test folder (which is what we want going forward). After this lands, I'll update the build definitions. |
Contributor
|
LGTM |
Contributor
|
@ellismg Doesn't the netci.groovy have to be updated? It has this now, |
Member
|
LGTM |
Contributor
Author
Yes. I'm fixing the script locally to work with and without the changes to netci.groovy and I will update netci.groovy as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6572 was merged, we only build test projects for the platforms
they test. This means the UnsupportedPlatforms metadata is no longer
needed (instead using the .builds file to control when the project is
built is the right thing to do).
Leverage this in run-test.sh, we now simply loop over all the tests in
the relevent folders under bin/tests, depending on the platform in
question.