Import XML Doc Comments for System.ComponentModel.EventBasedAsync#8282
Import XML Doc Comments for System.ComponentModel.EventBasedAsync#8282cartermp wants to merge 1 commit intodotnet:masterfrom
Conversation
|
In this case where we have the same classes in both files and no extra APIs, should we keep the comments in just one of the files? |
|
Good question. In this case one of the partial |
|
That's fine. But I'm thinking of how docfx detects the content and what if we need to make edits? Do we have to update it in two places? It becomes a maintenance nightmare. |
|
That's true. I see options here:
The second option is certainly easier. |
|
In this case, the #2 option seems to work since you have everything in the other file. That distinction is not that clear for cases like System.Reflection.Emit where the APIs are literally broken into the 2 files. |
65b52dc to
adf78e7
Compare
|
Done. |
|
Closing this out as we have a different plan for reference docs now. |
/cc @mairaw @Priya91