This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow whitespace after HTTP response header name#9208
Merged
Conversation
| } | ||
|
|
||
| internal static bool IsWhiteSpaceLatin1(byte c) | ||
| { |
Contributor
There was a problem hiding this comment.
You should add a comment about the space character (' ') as well since you listed all the others.
Member
Author
There was a problem hiding this comment.
I didn't add this, just moved it from below (GitHub doesn't show that well). But I can augment it.
Contributor
|
Add some comments. Otherwise, LGTM. |
stephentoub
force-pushed
the
fix_header_parsing
branch
2 times, most recently
from
e22608d to
2efad8a
Compare
Be a bit more lenient in what we allow in the formatting of response headers on Unix. The RFC states that "Each header field consists of a case-insensitive field name followed by a colon (":"), optional leading whitespace, the field value, and optional trailing whitespace." However, whitespace between the header name and the colon is accepted by WinHttpHandler, by the .NET Framework, and by all browsers on which I tried it, and servers can easily include such whitespace; if they do and we're not tolerant of it, requests to such servers will fail.
stephentoub
force-pushed
the
fix_header_parsing
branch
from
2efad8a to
888a01c
Compare
Merged
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…sing Allow whitespace after HTTP response header name Commit migrated from dotnet/corefx@ca0075e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be a bit more lenient in what we allow in the formatting of response headers.
Fixes https://github.com/dotnet/corefx/issues/9201
cc: @davidsh, @ericeil, @RicardoRazz