This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Remove use of DangerousGetPinnableReference and use Memory.GetReference instead#1985
Merged
Conversation
Member
|
@dotnet-bot test this please |
1 similar comment
Contributor
Author
|
@dotnet-bot test this please |
KrzysztofCwalina
pushed a commit
to KrzysztofCwalina/corefxlab
that referenced
this pull request
Jan 5, 2018
…ce instead (dotnet#1985) * Remove use of DangerousGetPinnableReference and use Memory.GetReference instead * Misses some references to DangerousGetPinnableReference in sample projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of:
https://github.com/dotnet/corefx/issues/25412
https://github.com/dotnet/corefx/issues/25615
Depends on the following to go through first:
dotnet/corefx#25961 (and subsequent consumption of CoreFx libraries in CoreFxLab)
I didn't find any uses of DangerousTryGetArray to remove.
Following the staging plan from here: https://github.com/dotnet/corefx/issues/23881#issuecomment-343767740
Doing it this way will avoid the need for complex staging or things being on the floor for extensive periods of time.
cc @jkotas, @stephentoub, @KrzysztofCwalina, @davidfowl, @pakrym, @joshfree, @eerhardt