[arm32 unix] The test Hello fails on arm32 because of difference between initializing and using structures

[sergign60]

The test Hello fails on arm32 because of difference between the initializing and using structures

The initializing structure for example in the following function supposes that the offset of the first pointer field equals to 24 bytes

MethodTable * System_Private_CoreLib::System::Object::__getMethodTable()
{
        static struct {
        unsigned char data0[24];
        void* reloc1;
        void* reloc2;
        void* reloc3;
        void* reloc4;

        } mt = {
                {0x00,0x00,0x00,0x00,0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x03,0x00,0x00,0x00,0xC1,0xB9,0x38,0xB7},
              __typemanager_indirection(),
              (void*)&System_Private_CoreLib::System::Object::ToString,
              (void*)&System_Private_CoreLib::System::Object::GetHashCode,
              (void*)&System_Private_CoreLib::System::Object::Equals,
        };
        return ( MethodTable * )&mt;
}

but in the using structure from the file (src/Native/Runtime/inc/eetype.h)

class EEType
{
...
#ifdef RHDUMP
public:
#else
private:
#endif
    struct RelatedTypeUnion
    {
        union 
        {
            // Kinds.CanonicalEEType
            EEType*     m_pBaseType;
            EEType**    m_ppBaseTypeViaIAT;

            // Kinds.ClonedEEType
            EEType** m_pCanonicalType;
            EEType** m_ppCanonicalTypeViaIAT;

            // Kinds.ParameterizedEEType
            EEType*  m_pRelatedParameterType;
            EEType** m_ppRelatedParameterTypeViaIAT;
#if defined(RHDUMP) || defined(BINDER)
            UIntTarget m_ptrVal;  // ensure this structure is the right size in cross-build scenarios
#endif // defined(RHDUMP) || defined(BINDER)
        };
    };

    UInt16              m_usComponentSize;
    UInt16              m_usFlags;
    UInt32              m_uBaseSize;
    RelatedTypeUnion    m_RelatedType;
    UInt16              m_usNumVtableSlots;
    UInt16              m_usNumInterfaces;
    UInt32              m_uHashCode;
#if defined(EETYPE_TYPE_MANAGER)
    TypeManagerHandle*  m_ppTypeManager;
#endif
    TgtPTR_Void         m_VTable[];  // make this explicit so the binder gets the right alignment

the offset of the first pointer field (m_ppTypeManager) equals to 20 bytes on arm32.

[sergign60]

CC: @jkotas @Dmitri-Botcharnikov

[jkotas]

The ilc compiler assumes that host platform = target platform right now.

I assume that you are using cross-compilation (the compiler is hosted on x64, producing code for arm), and thus the compiler does not know that you are doing cross-compilation. The best way to fix this is to add TargetPlatform command option that will let you set the target for cross-compilation:

corert/src/ILCompiler/src/Program.cs

Line 100 in 663ad88

private ArgumentSyntax ParseCommandLine(string[] args)

[sergign60]

#2793

[sergign60]

With the latest updates from the master branch the another error arises

1  0x00415c60 in RhGetOSModuleFromEEType (pEEType=0x584978 <System_Private_CoreLib::FxResources::System::Private::CoreLib::SR::__getMethodTable()::mt>)
    at /home/signatov/CORERT/corert/src/Native/Runtime/MiscHelpers.cpp:176
176	    return pEEType->GetTypeManagerPtr()->AsTypeManager()->GetOsModuleHandle();
Program received signal SIGSEGV, Segmentation fault.
TypeManager::GetOsModuleHandle (this=0xffffffff) at /home/signatov/CORERT/corert/src/Native/Runtime/TypeManager.cpp:168
168	    return m_osModule;

(gdb) p *pEEType
$2 = {m_usComponentSize = 0, m_usFlags = 0, m_uBaseSize = 12, m_RelatedType = {{m_pBaseType = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>, 
      m_ppBaseTypeViaIAT = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>, 
      m_pCanonicalType = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>, 
      m_ppCanonicalTypeViaIAT = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>, 
      m_pRelatedParameterType = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>, 
      m_ppRelatedParameterTypeViaIAT = 0x574330 <System_Private_CoreLib::System::Object::__getMethodTable()::mt>}}, m_usNumVtableSlots = 0, m_usNumInterfaces = 0, 
  m_uHashCode = 1534034976, m_ppTypeManager = 0x573098 <__typemanager_indirection()::mt>, 
  m_VTable = 0x584990 <guard variable for System_Private_CoreLib::FxResources::System::Private::CoreLib::SR::__getMethodTable()::mt>}

(gdb) p pEEType->m_ppTypeManager
$3 = (TypeManagerHandle *) 0x573098 <__typemanager_indirection()::mt>
(gdb) p *pEEType->m_ppTypeManager
$4 = {_value = 0x0}

[jkotas]

p *pEEType->m_ppTypeManager

This should be initialized by section->TypeManager = typeManager in InitializeGlobalTablesForModule. The C++ boostrap code calls InitializeModules and InitializeModules calls InitializeGlobalTablesForModule.

What is the stacktrace of the crash?

[sergign60]

@jkotas

#1  0x00367590 in System_Private_CoreLib::System::Runtime::RuntimeImports::RhGetOSModuleFromEEType (_a0=5876688) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:529657
(gdb) bt
#0  RhGetOSModuleFromEEType (pEEType=0x59abd0 <System_Private_CoreLib::FxResources::System::Private::CoreLib::SR::__getMethodTable()::mt>)
    at /home/signatov/CORERT/corert/src/Native/Runtime/MiscHelpers.cpp:180
#1  0x00367590 in System_Private_CoreLib::System::Runtime::RuntimeImports::RhGetOSModuleFromEEType (_a0=5876688) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:529657
#2  0x0034f47a in System_Private_CoreLib::System::RuntimeTypeHandle::get_LastResortToString (_a0=0x7effe794) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:477918
#3  0x0033c0ee in System_Private_CoreLib::Internal::Runtime::Augments::RuntimeAugments::GetLastResortString (_a0=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:426035
#4  0x0003968a in System_Private_Reflection_Execution::Internal::Reflection::Execution::ExecutionEnvironmentImplementation::GetLastResortString (_a0=0x73012568, _a1=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:382788
#5  0x002ea3c6 in System_Private_Reflection_Core::System::Reflection::Runtime::General::Helpers::LastResortString (_a0=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:292479
#6  0x000f59f6 in System_Private_Reflection_Core::System::Reflection::Runtime::TypeInfos::RuntimeNoMetadataNamedTypeInfo::ToString (_a0=0x730313c8)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:248139
#7  0x002c47f0 in System_Private_Reflection_Core::System::Reflection::Runtime::TypeInfos::RuntimeTypeInfo::EstablishDebugName (_a0=0x730313c8)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:292823
#8  0x002ab67e in System_Private_Reflection_Core::System::Reflection::Runtime::TypeInfos::RuntimeNoMetadataNamedTypeInfo::GetRuntimeNoMetadataNamedTypeInfo (_a0=..., _a1=0 '\000')
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:197812
#9  0x002937c4 in System_Private_Reflection_Core::Internal::Reflection::Core::Execution::ExecutionDomain::GetNamedTypeForHandle (_a0=0x730126fc, _a1=..., _a2=0 '\000')
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:167323
#10 0x00062b22 in System_Private_Reflection_Execution::Internal::Reflection::Execution::ReflectionExecutionDomainCallbacksImplementation::GetNamedTypeForHandle (_a0=0x73012718, 
    _a1=..., _a2=0 '\000') at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:138364
#11 0x0008274a in System_Private_CoreLib::Internal::Reflection::Core::NonPortable::RuntimeTypeUnifier_RuntimeTypeHandleToTypeCache::Factory (_a0=0x73030414, _a1=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:98645
#12 0x00249ba8 in System_Private_CoreLib::System::Collections::Concurrent::ConcurrentUnifierW_2_A__System_Private_CoreLib_Internal_Reflection_Core_NonPortable_RawRuntimeTypeHandleKey___System_Private_CoreLib_System_Type_V_::GetOrAdd_A__V_ (_a0=0x73030414, _a1=...) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:59708
#13 0x002379e6 in System_Private_CoreLib::Internal::Reflection::Core::NonPortable::RuntimeTypeUnifier::GetTypeForRuntimeTypeHandle (_a0=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:40202
#14 0x0023b43c in System_Private_CoreLib::Internal::Reflection::Core::NonPortable::ReflectionCoreNonPortable::GetTypeForRuntimeTypeHandle (_a0=...)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:29049
#15 0x0022e59e in System_Private_CoreLib::System::Type::GetTypeFromHandle (_a0=...) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:21023
#16 0x00249e80 in System_Private_CoreLib::System::SR::get_ResourceType () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:59085
#17 0x00232c52 in System_Private_CoreLib::System::SR::get_ResourceManager () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:40634
#18 0x00224fa6 in System_Private_CoreLib::System::SR::GetResourceString_0 (_a0=0x73030290, _a1=0x730302d8) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:15994
#19 0x003a18fe in System_Private_CoreLib::System::SR::get_Argument_EncodingNotSupported () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:627407
#20 0x0039c946 in System_Private_CoreLib::System::Text::EncodingTable::InternalGetCodePageFromName (_a0=0x7302e738)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:587094
#21 0x00180644 in System_Private_CoreLib::System::Text::EncodingTable_NameToCodePageCache::Factory (_a0=0x7302e058, _a1=0x7302e034)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:578669
#22 0x003727f8 in System_Private_CoreLib::System::Collections::Concurrent::ConcurrentUnifier_2_A__System_Private_CoreLib_System_String___System_Private_CoreLib_System_Object_V_::GetOrAdd_A__V_ (_a0=0x7302e058, _a1=0x7302e034) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:515030
#23 0x003421b6 in System_Private_CoreLib::System::Text::EncodingTable::GetCodePageFromName (_a0=0x7302e034) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:497490
#24 0x00333ef6 in System_Private_CoreLib::System::Text::Encoding::GetEncoding_1 (_a0=0x7302e034) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:396264
#25 0x002eea9c in System_Console::System::Text::EncodingHelper::GetEncodingFromCharset () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:369592
#26 0x002dcf5a in System_Console::System::ConsolePal::GetConsoleEncoding () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:256017
#27 0x00298722 in System_Console::System::ConsolePal::get_OutputEncoding () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:229194
#28 0x0028cb88 in System_Console::System::Console___c::_get_OutputEncoding_b__18_0 (_a0=0x73012ecc) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:142930
#29 0x0028cc38 in System_Console::System::Console::EnsureInitialized_A__System_Private_CoreLib_System_Text_Encoding_V_ (_a0=0x5ce1d0 <__gcStatics+472>, _a1=0x73013308)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:142971
#30 0x00263198 in System_Console::System::Console::get_OutputEncoding () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:128946
#31 0x0025dd12 in System_Console::System::Console::CreateOutputWriter (_a0=0x730132e4) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:75158
#32 0x002410de in System_Console::System::Console___c::_get_Out_b__25_0 (_a0=0x73012ecc) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:70736
#33 0x0024118e in System_Console::System::Console::EnsureInitialized_A__System_Runtime_Extensions_System_IO_TextWriter_V_ (_a0=0x5ce1c4 <__gcStatics+460>, _a1=0x73012ed8)
    at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:69756
#34 0x0023d516 in System_Console::System::Console::get_Out () at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:24816
#35 0x0022416a in System_Console::System::Console::WriteLine_12 (_a0=0x73012e90) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:22076
---Type <return> to continue, or q <return> to quit---
#36 0x00222e62 in Hello::Hello::Program::Main (args=0x73012e84) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/Hello.cs:17
#37 0x002131c6 in Hello::_Module_::MainMethodWrapper (_a0=0x73012e84) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:279586
#38 0x00212fc2 in Hello::_Module_::StartupCodeMain (_a0=1, _a1=2130704164) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:266524
#39 0x00213204 in __managed__Main (_a0=1, _a1=2130704164) at /home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:266531
#40 0x004143be in main (argc=1, argv=0x7efff724) at /home/signatov/CORERT/corert/src/Native/Bootstrap/main.cpp:319

[jkotas]

I would set breakpoint around System_Private_CoreLib::System::Text::EncodingTable::GetCodePageFromName. It is where something went wrong. System_Private_CoreLib::System::SR::get_Argument_EncodingNotSupported should not be called at all.

I see that you are not getting good line numbers for S.P.CoreLib and System.Console ... debugging is hard without good line numbers. ilc will pick up the .pdb file next to the .dll. Make sure that you have the .pdb file next to S.P.CoreLib. For System.Console, build your own System.Console in corefx repo and pass it to ilc compiler with the matching .pdb file next to it.

[sergign60]

@jkotas ok, thanks for your help!

[sergign60]

@jkotas

I see another problem now:

The generated function RtRHeaderWrapper is the same for both 64 and 32-bit versions

void* RtRHeaderWrapper() {
static struct {
unsigned char leftPadding[8];
void* rtrHeader;
unsigned char rightPadding[8];
} rtrHeaderWrapper = {
{ 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00 },
(void*)__ReadyToRunHeader(),
{ 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00 }
};
return (void *)&rtrHeaderWrapper;
}

but when the address of rtrHeaderWrapper is passed into another generated function System_Private_CoreLib::Internal::Runtime::CompilerHelpers::StartupCodeHelpers::CreateTypeManagers as its second operand, the following inconcintence arises

	intptr_t _41 = _40 * (int32_t)sizeof(::System_Private_CoreLib::System::IntPtr);
	intptr_t _42 = _38 + _41;
	intptr_t _43 = *(intptr_t*)_42;

the value of _41 equals 4 for 32-bit version, so the value of _43 equals 0 also.

So I can guess that the size of unsigned char leftPadding[] should be 4 for 32-bit verison.

[sergign60]

#2903

[sergign60]

@jkotas
The test Hello passes with the latest updates!

s.ignatov@raspberrypi:~ $ ./Hello
Usage: hello name
s.ignatov@raspberrypi:~ $ ./Hello Serg
Hello Serg
s.ignatov@raspberrypi:~ $ ./Hello JKotas
Hello JKotas
s.ignatov@raspberrypi:~ $ uname -a 
Linux raspberrypi 4.1.19-v7+ #858 SMP Tue Mar 15 15:56:00 GMT 2016 armv7l GNU/Linux
s.ignatov@raspberrypi:~ $ env | grep LANG
LANG=en_US.UTF-8
s.ignatov@raspberrypi:~ $ file ./Hello
./Hello: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.3, for GNU/Linux 3.2.0, not stripped

The used configuration is armel tizen
I think we can close this issue

s.ignatov@raspberrypi:~ $ ./PInvoke
Testing marshalling blittable types
Testing marshalling boolean
Testing Unichar
Testing marshalling int arrays
Testing marshalling blittable struct arrays
Call to an unimplemented runtime method; execution cannot continue.
Method: RhpThrowEx

[jkotas]

Nice :-)