[CppCodeGen] System::DateTime::ToString crash

[cocotr]

Hello,
I have compiled the same code on Ubuntu 16.04 once with just /t:LinkNative and second time with /t:LinkNative /p:NativeCodeGen=cpp.
The one which was compiled just only with /t:LinkNative works properly, but when I try to run program compiled with /t:LinkNative /p:NativeCodeGen=cpp I get an error: "Segmentation fault (core dumped)".
How to check what causes the problem?

Thanks

[MichalStrehovsky]

@cocotr If you run the produced executable under a debugger, the stack trace might be helpful.

You can have a look at the list of known issues in CppCodegen. Maybe you can map your issue to one of them.

[tijoytom-zz]

@cocotr Can please try deleting the obj directory ? I have seen this happening with incremental build. Feel free to open an issue.

[cocotr]

I deleted both obj and bin directory and then dotnet restore and then compilation. Both compiled successfully but only compiled with /t:LinkNative runs properly

[cocotr]

Which debugger do you use ?

[MichalStrehovsky]

Which debugger do you use ?

The code gets compiled with clang, so lldb would be a good choice.

[cocotr]

Hi,
I did backtrace with lldb. Any ideas how to fix it ?

(lldb) thread backtrace
* thread #1: tid = 26677, 0x0000000000000000, name = 'test', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
  * frame #0: 0x0000000000000000
    frame #1: 0x00000000007ead09 test`System_Private_CoreLib::System::Text::StringBuilder::AppendFormatHelper(_a0=0x00007fffdc8c10c0, _a1=0x00007fffdc898ed8, _a2=0x00007fffdc8c0f40, _a3=ParamsArray @ 0x00007fffffffc390) + 7689 at Program.cs:22508
    frame #2: 0x00000000007da437 test`System_Private_CoreLib::System::String::FormatHelper(_a0=0x00007fffdc898ed8, _a1=0x00007fffdc8c0f40, _a2=ParamsArray @ 0x00007fffffffc4b0) + 439 at Program.cs:953
    frame #3: 0x000000000094f7cb test`System_Private_CoreLib::System::String::Format_4(_a0=0x00007fffdc898ed8, _a1=0x00007fffdc8c0f40, _a2=0x00007fffdc8c1030) + 171 at DJXMessageChecker_WithSpecialPatterns.cs:116267
    frame #4: 0x0000000000a7a8f2 test`System_Private_CoreLib::System::Globalization::CalendarData::NormalizeDatePattern(_a0=0x00007fffdc8c0e68) + 1922 at DJXMessageChecker_WithSpecialPatterns.cs:393261
    frame #5: 0x0000000000a452a1 test`System_Private_CoreLib::System::Globalization::CalendarData::LoadCalendarDataFromSystem(_a0=0x00007fffdc8c06e0, _a1=0x00007fffdc89b4d8, _a2=1) + 305 at DJXMessageChecker_WithSpecialPatterns.cs:278568
    frame #6: 0x00000000009b7060 test`System_Private_CoreLib::System::Globalization::CalendarData::_ctor_0(_a0=0x00007fffdc8c06e0, _a1=0x00007fffdc89b4d8, _a2=1, _a3='\x01') + 288 at DJXMessageChecker_WithSpecialPatterns.cs:229571
    frame #7: 0x000000000097192e test`System_Private_CoreLib::System::Globalization::CultureData::GetCalendar(_a0=0x00007fffdc89aba0, _a1=1) + 734 at DJXMessageChecker_WithSpecialPatterns.cs:124740
    frame #8: 0x00000000009b3f5f test`System_Private_CoreLib::System::Globalization::CultureData::ShortDates(_a0=0x00007fffdc89aba0, _a1=1) + 63 at DJXMessageChecker_WithSpecialPatterns.cs:202195
    frame #9: 0x0000000000971a7f test`System_Private_CoreLib::System::Globalization::CultureData::DateSeparator(_a0=0x00007fffdc89aba0, _a1=1) + 63 at DJXMessageChecker_WithSpecialPatterns.cs:124614
    frame #10: 0x0000000000953a09 test`System_Private_CoreLib::System::Globalization::DateTimeFormatInfo::InitializeOverridableProperties(_a0=0x00007fffdc8bf100, _a1=0x00007fffdc89aba0, _a2=1) + 1017 at DJXMessageChecker_WithSpecialPatterns.cs:146953
    frame #11: 0x000000000090b8f4 test`System_Private_CoreLib::System::Globalization::DateTimeFormatInfo::set_Calendar(_a0=0x00007fffdc8bf100, _a1=0x00007fffdc8bf0e0) + 1636 at DJXMessageChecker_WithSpecialPatterns.cs:58535
    frame #12: 0x00000000008f865c test`System_Private_CoreLib::System::Globalization::DateTimeFormatInfo::_ctor_0(_a0=0x00007fffdc8bf100, _a1=0x00007fffdc89aba0, _a2=0x00007fffdc8bf0e0) + 1292 at DJXMessageChecker_WithSpecialPatterns.cs:17808
    frame #13: 0x000000000046d760 test`System_Private_CoreLib::System::Globalization::CultureInfo::get_DateTimeFormat(_a0=0x00007fffdc89a9f0) + 208 at ConsoleStreamWriterWithStringBuilderBuffer.cs:2010
    frame #14: 0x000000000046d4ec test`System_Private_CoreLib::System::Globalization::CultureInfo::GetFormat(_a0=0x00007fffdc89a9f0, _a1=0x00007fffdc8baa98) + 316 at ExtensionMethods.cs:24639
    frame #15: 0x000000000081a966 test`System_Private_CoreLib::System::Globalization::DateTimeFormatInfo::get_CurrentInfo() + 310 at ExtensionMethods.cs:264
    frame #16: 0x00000000007e47ac test`System_Private_CoreLib::System::DateTime::ToString(_a0=0x00007fffffffdcf0) + 44 at Program.cs:24424
    frame #17: 0x00000000007db749 test`test::DJCF_SprawdzanieHeadlinow_NETCore::Program::Main(args=0x00007fffdc898e58) + 89 at Program.cs:13
    frame #18: 0x00000000007bf050 test`test::_Module_::MainMethodWrapper(_a0=0x00007fffdc898e58) + 32 at test.cpp:307917
    frame #19: 0x00000000007bebd1 test`test::_Module_::StartupCodeMain(_a0=1, _a1=140737488346888) + 113 at test.cpp:296150
    frame #20: 0x00000000007bf0bb test`::__managed__Main(_a0=1, _a1=140737488346888) + 27 at test.cpp:296157
    frame #21: 0x0000000000cf3e4f test`main(argc=1, argv=0x00007fffffffdf08) + 191 at main.cpp:319
    frame #22: 0x00007ffff6b64830 libc.so.6`__libc_start_main(main=(test`main at main.cpp:278), argc=1, argv=0x00007fffffffdf08, init=<unavailable>, fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffffffdef8) + 240 at libc-start.c:291
    frame #23: 0x000000000040a169 test`_start + 41
(lldb) 

[jkotas]

I did backtrace with lldb. Any ideas how to fix it ?

It looks like that a bad code gets generated by the IL to C++ transpiler.

Could you please share small repro for the crash?

[jkotas]

This was likely duplicate of #4403

[am11]

@jkotas, @hippiehunter, this issue seems to be different than #4403 and still persists with current master (cb4c34e).

With ToString()

using System;
internal class Program
{
   private static void Main(string[] args)
        => Console.WriteLine(DateTime.UtcNow.ToString());
}

I get:

Call to an unimplemented runtime method; execution cannot continue.
Method: RhpThrowEx

In my testing, there seems to be a general problem with ToString(), not only DateTime, but Enum.ToString() also complains about RhpThrowEx.

---

Without ToString()

using System;
internal class Program
{
   private static void Main(string[] args)
        => Console.WriteLine(DateTime.UtcNow);
}

It throws an NYI assertion:

Debug Assertion Violation

Message: NYI

Expression: 'ASSERT_UNCONDITIONALLY'

File: C:\Users\Adeel\Source\Repos\corert\src\Native\Runtime\portable.cpp, Line: 431

[am11]

The Enum.ToString() case is bit different and is independent of System.Globalization: #4558.

For DateTime without ToString(), it's simply that the PINVOKE helper with RhGetCommonStubAddress is not implemented. Since RhGetCommonStubAddress is defined in ASM/S for all the supported architectures; do we need to re-link it via COOP_PINVOKE_HELPER

corert/src/Native/Runtime/portable.cpp

Line 429 in cb4c34e

COOP_PINVOKE_HELPER(void *, RhGetCommonStubAddress, ())

(which eventually expands to extern "C")?