X86 runtime build fails

[morganbr]

There are a number of failures building for x86. This should be doable since the same sources get built for x86 as part of .NET Native.

8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(96): error C2143: syntax error: missing ';' before '*' [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(96): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(173): error C3646: 'm_pRuntimeFunctionTable': unknown override specifier [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(173): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(229): error C3646: 'AllocRuntimeFunction': unknown override specifier [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(229): error C2059: syntax error: '(' [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\jitinterface\JITCodeManager.h(229): error C2238: unexpected token(s) preceding ';' [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
8>e:\corert\corert\src\native\runtime\coreclr\gcinfotypes.h(326): fatal error C1083: Cannot open include file: 'bitvector.h': No such file or directory [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\jitinterface\jitinterface.vcxproj]
4>E:\corert\corert\src\Native\Runtime\thread.cpp(600): error C2664: 'UInt32 PalHijack(HANDLE,PalHijackCallback,void *)': cannot convert argument 2 from 'UInt32_BOOL (__cdecl *)(HANDLE,PAL_LIMITED_CONTEXT *,void *)' to 'PalHijackCallback' [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkCommon.cpp(225): error C2373: 'PalGetProcessCpuCount': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
E:\corert\corert\src\Native\Runtime\PalRedhawk.h(694): note: see declaration of 'PalGetProcessCpuCount'
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkCommon.cpp(249): error C2373: 'PalReadFileContents': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
E:\corert\corert\src\Native\Runtime\PalRedhawk.h(696): note: see declaration of 'PalReadFileContents'
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkCommon.cpp(285): error C2373: 'PalGetMaximumStackBounds': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
E:\corert\corert\src\Native\Runtime\PalRedhawk.h(701): note: see declaration of 'PalGetMaximumStackBounds'
PalRedhawkMinWin.cpp
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkMinWin.cpp(115): error C2373: 'PalAttachThread': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
e:\corert\corert\src\native\runtime\PalRedhawk.h(822): note: see declaration of 'PalAttachThread'
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkMinWin.cpp(137): error C2373: 'PalDetachThread': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
e:\corert\corert\src\native\runtime\PalRedhawk.h(823): note: see declaration of 'PalDetachThread'
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkMinWin.cpp(192): error C2373: 'PalGetModuleFileName': redefinition; different type modifiers [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
e:\corert\corert\src\native\runtime\PalRedhawk.h(704): note: see declaration of 'PalGetModuleFileName'
4>E:\corert\corert\src\Native\Runtime\windows\PalRedhawkMinWin.cpp(1811): error C2664: 'HANDLE CreateThread(LPSECURITY_ATTRIBUTES,SIZE_T,LPTHREAD_START_ROUTINE,LPVOID,DWORD,LPDWORD)': cannot convert argument 3 from 'DWORD (__cdecl *)(void *)' to 'LPTHREAD_START_ROUTINE' [E:\corert\corert\bin\obj\Native\Windows_NT.x86.Debug\Runtime\Portable\PortableRuntime.vcxproj]
E:\corert\corert\src\Native\Runtime\windows\PalRedhawkMinWin.cpp(1811): note: None of the functions with this name in scope match the target type

[am11]

Hey @morganbr, I gave it a shot out of curiosity and got to a point where it requires to implement/port more unwinding features for x86 in and around JITCodeManager. One suggestion (which may cleanup some code): port CoreCLR's REGALIAS implementation to deal with E-family i386 registers. I used some ifdefs to deal with them and altered the macro code such as this.

[jkotas]

JITCodeManager can be excluded from the i386 completely (ie it can be included for x64 only). It is experimental component that is not required for CoreRT to work today.

[jkotas]

https://github.com/dotnet/corert/blob/master/src/Native/jitinterface/CMakeLists.txt#L10 is a good place to do it.

[am11]

The native parts now build on x86, for managed parts, I think aside from dotnet-cli for x86 Linux/Windows, we need to object-writer from LLILC for Linux-x86 (along with linux-x64, alpine.3.6-x64) RIDs. Something similar to this: dotnet/llilc@8dc6363.

@jkotas, @janvorli, (unless ObjectWriter build has dependency on CoreCLR and LLVM) are there plans to bring ObjectWriter to CoreRT repo as there has been no activity in llilc repo in a while. I suppose, this package in CoreRT repo will be comparatively well-maintained and continuously update to new RID conventions (e.g. runtime.{RID}.{Arch}.{PackageName} instead of old toolchain.{RID}.{Arch}.{PackageName} naming).

[jkotas]

We have been re-building ObjectWriter package from llilc repo manually as needed because of it is not changing frequently. Having the source for it in CoreRT repo makes sense. The plan can be something like:

• Copy over https://github.com/dotnet/llilc/tree/ObjectWriter/lib/ObjWriter to corert\src\Native\objwriter
• Add script and documentation on how to do one-off build

[am11]

@jkotas, the one-off build appears to be quite involved if we follow the documented build steps. I ended up compiling entire LLILC repo (ObjectWriter branch) as an LLVM plugin. Tested only the Windows x64 build, as there are missing x86 implementations which I guess would require a separate effort. With current infrastructure, we have to first compile CoreCLR, then LLILC as LLVM's tool. This can probably be re-wired in ObjectWriter's cmake script to reduce the amount of steps and repos to clone.

Is it a possibility that dependency on ObjectWriter for ILC is removed in future or ObjectWriter's dependency on LLVM is substituted with custom implementation?

[jkotas]

With current infrastructure, we have to first compile CoreCLR

Compiling CoreCLR should not be required to compile ObjectWriter.

dependency on ObjectWriter for ILC is removed in future

We have used ObjectWriter to bootstrap the project faster. We went back and forth on whether/when we should replace it with custom implementation. There is no immediate plan to remove it, but there is a chance that it will be removed in future.