This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Add EnvironmentAugments to corert#1496
Merged
Merged
Conversation
Member
|
LGTM (with the same comments as in dotnet/coreclr#6205). |
| public static void Exit(int exitCode) => Environment.Exit(exitCode); | ||
| public static int ExitCode { get { return 0; } set { throw new PlatformNotSupportedException(); } } | ||
| public static void FailFast(string message, Exception error) => Environment.FailFast(message, error); | ||
| public static string[] GetCommandLineArgs() => Environment.GetCommandLineArgs(); |
Member
There was a problem hiding this comment.
This will cause build break when integrated to TFS. Environment.GetCommandLineArgs was not implemented for .NET Native for UWP yet - it is under CORERT ifdef. We should remove the CORERT ifdef in Environment.cs. It won't make it work, but it will be good enough to fix the build break.
And avoid null ref if GetCommandLineArgs is called without SetCommandLineArgs having been called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of dotnet/corefx#9851
cc: @jkotas, @danmosemsft