Port Encoding.GetEncoding(int) changes from CoreCLR#1726
Conversation
|
We'll only be able to get rid of the TODO once CppCodegen can do interface calls, if my comment from the February pull request is right (I did constrained calls a while ago). We're getting closer, but we're not there yet. |
The change is getting rid of the unifier hashtable that contains the constrained calls on this codepath, so it should be fine to remote the TODO on this codepath. However, it exposed a different problem in CppCodeGen. There is a problem with string literals mangling: |
|
@justinvp Could you please add the ifdef & TODO back? We will look at the CppCodeGen break separately. |
Port dotnet/coreclr#6907 from CoreCLR. Remove EncodingCache and cache UTF32BE in a static field.
7ce91da to
2ec31f0
Compare
@jkotas, done. |
|
Thanks! |
|
FYI, I opened #1727 about the string literal issue. |
Port dotnet/coreclr#6907 from CoreCLR.
Remove
EncodingCacheand cache UTF32BE in a static field.