This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Add single separator String.Split overloads#1845
Merged
Merged
Conversation
| //-------------------------------------------------------------------- | ||
| [System.Security.SecuritySafeCritical] // auto-generated | ||
| private unsafe int MakeSeparatorList(string separator, int[] sepList) | ||
| { |
Member
There was a problem hiding this comment.
Nit - the security critical annotations were stripped from corert.
Contributor
Author
There was a problem hiding this comment.
Forgot to strip it. Fixed.
justinvp
force-pushed
the
string_split
branch
from
b076dc5 to
283c31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of dotnet/coreclr#895 and dotnet/coreclr#7175
cc: @jkotas