Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Fixed Join(string separator, params object[] values) method#2203

Merged
jkotas merged 1 commit into
dotnet:masterfrom
AlexRadch:String.Join.Fix.16.11.14
Nov 16, 2016
Merged

Fixed Join(string separator, params object[] values) method#2203
jkotas merged 1 commit into
dotnet:masterfrom
AlexRadch:String.Join.Fix.16.11.14

Conversation

@AlexRadch
Copy link
Copy Markdown
Contributor

Fixed Join(string separator, params object[] values) method.
Calling string.Join(",", null, 1, 2, 3); return empty string but should ",1,2,3".

Fixed Join(string separator, params object[] values) method.
Calling string.Join(",", null, 1, 2, 3); return empty string but should ",1,2,3".
@dnfclas
Copy link
Copy Markdown

dnfclas commented Nov 14, 2016

Hi @AlexRadch, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Nov 14, 2016

@AlexRadch Thanks for submitting the fix. We are doing the behavior changes like this one in coreclr/corefx first, and only then porting them to corert.

This issue is tracked as https://github.com/dotnet/coreclr/issues/4506. Check the discussion there - it is a tricky one because of this behavior is explicitly mentioned in the documentation.

@dnfclas
Copy link
Copy Markdown

dnfclas commented Nov 16, 2016

@AlexRadch, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas
Copy link
Copy Markdown

dnfclas commented Nov 16, 2016

@AlexRadch, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Nov 16, 2016

Matching CoreCLR issue was merged dotnet/coreclr#8114

@jkotas jkotas merged commit 567a028 into dotnet:master Nov 16, 2016
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Nov 16, 2016

@AlexRadch Thanks!

@AlexRadch AlexRadch deleted the String.Join.Fix.16.11.14 branch November 17, 2016 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants