This repository was archived by the owner on Nov 1, 2020. It is now read-only.
TimeZoneInfo Cleanup#2408
Merged
Merged
Conversation
Some cleanup in CoreRT's TimeZoneInfo implementation: - The CachedData locking is currently inconsistent. Some code is using a private Lock object with LockHolder.Hold, while other code is locking against the CachedData instance. This change removes the private Lock object and just locks against the CachedData instance throughout, which is consistent with the CoreCLR implementation. - TimeZoneInfoComparer is being used in two places in CoreRT to sort the list of system time zones, whereas it's only used in one place in CoreCLR. This change refactors the code to have a shared implementation of GetSystemTimeZones in CoreRT that handles the sorting in one place, allowing a single Comparison<T> lambda to be used, which matches the CoreCLR implementation. Now there is a single shared GetSystemTimeZones implementation which calls a private static PopulateAllSystemTimeZones method, which is implemented separately for Win32/WinRT/Unix. - The WinRT implementation of FindSystemTimeZoneById was accessing the cached data without any locking. Added locking.
justinvp
force-pushed
the
tzi_comparison
branch
from
612aa1a to
785504c
Compare
Member
|
LGTM. @jkotas PTAL. |
Member
|
Looks great! @justinvp Thanks a lot for going an extra mile to clean it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup in CoreRT's TimeZoneInfo implementation:
The
CachedDatalocking is currently inconsistent. Some code is using a privateLockobject withLockHolder.Hold, while other code is locking against theCachedDatainstance (viaMonitor.Enter/Exit). This change removes the privateLockobject and just locks against theCachedDatainstance throughout, which is consistent with the CoreCLR implementation.TimeZoneInfoCompareris being used in two places in CoreRT to sort the list of system time zones, whereas it's only used in one place in CoreCLR. This change refactors the code to have a shared implementation ofGetSystemTimeZonesin CoreRT that handles the sorting in one place, allowing a singleComparison<T>lambda to be used, which matches the CoreCLR implementation. Now the single sharedGetSystemTimeZonesimplementation calls a private staticPopulateAllSystemTimeZonesmethod, which has separate implementations for Win32/WinRT/Unix. This addresses porting Remove private TimeZoneInfoComparer coreclr#8512.The WinRT implementation of
FindSystemTimeZoneByIdwas accessing the cached data without any locking. Added locking.cc: @tarekgh, @jkotas
Fixes #2388