[Arm Unix build] Fixes for cross building corert tests for arm architectures on Linux by sergign60 · Pull Request #2682 · dotnet/corert

sergign60 · 2017-02-08T17:44:06Z

This pull request contains fixes for the cross building corert tests for arm architectures (arm&armel) on Ubuntu 16.04 x64.

Unfortunately, there are two problems just now:

The following error arises during building jit-variants of tests

       IlcCompile:
         Creating directory ".../corert/tests/src/Simple/Delegates/obj/Debug/armel/native/".
         ".../corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/corerun" ".../corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/ilc.dll" @".../corert/tests/src/Simple/Delegates/obj/Debug/armel/native/Delegates.ilc.rsp"
         
         Unhandled Exception: System.DllNotFoundException: Unable to load DLL 'jitinterface': The specified module could not be found.
          (Exception from HRESULT: 0x8007007E)
            at Internal.JitInterface.CorInfoImpl.GetJitHost(IntPtr configProvider)
            at Internal.JitInterface.CorInfoImpl..ctor(Compilation compilation, JitConfigProvider jitConfig)
            at ILCompiler.RyuJitCompilation.CompileInternal(String outputFile)
            at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String outputFile)
            at ILCompiler.Program.Run(String[] args)
            at ILCompiler.Program.Main(String[] args)
         Aborted (core dumped)

x64 native variant doesn't create this fail.

I don't know yet how to pass archtecture-specific c++ compiler options for building cpp-variant of tests

any help will be accepted with gratitude

dnfclas · 2017-02-08T17:44:11Z

Hi @sergign60, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

sergign60 · 2017-02-08T17:44:32Z

CC: @Dmitri-Botcharnikov

jkotas · 2017-02-08T21:03:17Z

    <OutputType Condition="'$(OutputType)' == ''">Exe</OutputType>
-    <OutputPath>$(MSBuildProjectDirectory)\bin\$(Configuration)\</OutputPath>
-    <IntermediateOutputPath>$(MSBuildProjectDirectory)\obj\$(Configuration)\</IntermediateOutputPath>
+    <OutputPath>$(MSBuildProjectDirectory)\bin\$(Configuration)\$(Variant)\</OutputPath>


It is common to call this Platform. Do we have some prior art somewhere where it is called Variant?

@jkotas Changed

jkotas · 2017-02-08T21:04:57Z

I don't know yet how to pass archtecture-specific c++ compiler options for building cpp-variant of tests

It is done here: https://github.com/dotnet/corert/blob/master/src/BuildIntegration/Microsoft.NETCore.Native.Unix.props#L29

jkotas · 2017-02-08T21:07:42Z

The following error arises during building jit-variants of tests

libjitinterface.so is part of the compiler, so it needs to be built on the host architecture.

It is easier to make a simple hello world running first using the cppcodegen option. You may do that first and then work on the RyuJIT one. The RyuJIT one is more involved.

sergign60 · 2017-02-09T10:36:14Z

@jkotas many thanks!

jkotas · 2017-02-10T00:11:49Z

        )
    )

-    echo msbuild /m /ConsoleLoggerParameters:ForceNoAlign "/p:IlcPath=%CoreRT_ToolchainDir%" "/p:Configuration=%CoreRT_BuildType%" "/p:RepoLocalBuild=true" "/p:FrameworkLibPath=%~dp0\..\bin\Product\%CoreRT_BuildOS%.%CoreRT_BuildArch%.%CoreRT_BuildType%\lib" "/p:FrameworkObjPath=%~dp0\..\bin\obj\Product\%CoreRT_BuildOS%.%CoreRT_BuildArch%.%CoreRT_BuildType%\Framework" !extraArgs! !__SourceFile!.csproj


Nit: Indentation

@jkotas fixed

sergign60 · 2017-02-13T09:15:48Z

@jkotas

Now I get the following error:

         clang-3.9 -target arm-linux-gnueabi --sysroot=/home/signatov/CORERT/corert/tests/../cross/rootfs/armel -B/home/signatov/CORERT/corert/tests/../cross/rootfs/armel/usr/lib/gcc/armv7l-tizen-linux-gnueabi/4.9.2 -L/home/signatov/CORERT/corert/tests/../cross/rootfs/armel/usr/lib/gcc/armv7l-tizen-linux-gnueabi/4.9.2 /home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.o -o /home/signatov/CORERT/corert/tests/src/Simple/Hello/bin/Debug/armel/native/Hello /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libbootstrappercpp.a /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libPortableRuntime.a /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libSystem.Private.CoreLib.Native.a /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/framework/System.Native.a /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/framework/libSystem.Globalization.Native.a -g -pthread -lstdc++ -ldl -lm -lrt
         /home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/framework/System.Native.a: error adding symbols: File format not recognized

As I understand I need the arm versions of System.Native.a (and libSystem.Globalization.Native.a) Which way can I get them?

sergign60 · 2017-02-13T10:54:55Z

@jkotas I've created the issue #2739

sergign60 · 2017-02-13T12:24:10Z

@jkotas I take armel versions of System.Native.a from CoreFX and libSystem.Globalizaiton.Native.a from CoreCLR and get the following list of unresolved variables

/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.o: In function `System_Private_CoreLib::System::Runtime::InternalCalls::RhpNewFastMisalign(System_Private_CoreLib::Internal::Runtime::EEType*)':
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:(.text+0x1fe50a): undefined reference to `RhpNewFastMisalign'
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.o: In function `System_Private_CoreLib::System::Runtime::InternalCalls::RhpNewFinalizableAlign8(System_Private_CoreLib::Internal::Runtime::EEType*)':
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:(.text+0x1fe556): undefined reference to `RhpNewFinalizableAlign8'
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.o: In function `System_Private_CoreLib::System::Runtime::InternalCalls::RhpNewFastAlign8(System_Private_CoreLib::Internal::Runtime::EEType*)':
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:(.text+0x1fe56a): undefined reference to `RhpNewFastAlign8'
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.o: In function `System_Private_CoreLib::System::Runtime::InternalCalls::RhpNewArrayAlign8(System_Private_CoreLib::Internal::Runtime::EEType*, int)':
/home/signatov/CORERT/corert/tests/src/Simple/Hello/obj/Debug/armel/native/Hello.cpp:(.text+0x1fe646): undefined reference to `RhpNewArrayAlign8'
/home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libPortableRuntime.a(RuntimeInstance.cpp.o):(.data.rel.ro+0x0): undefined reference to `RhpNewFinalizableAlign8'
/home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libPortableRuntime.a(RuntimeInstance.cpp.o):(.data.rel.ro+0x4): undefined reference to `RhpNewFastMisalign'
/home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libPortableRuntime.a(RuntimeInstance.cpp.o):(.data.rel.ro+0x8): undefined reference to `RhpNewFastAlign8'
/home/signatov/CORERT/corert/tests/../bin/Product/Linux.armel.Debug/packaging/publish1/sdk/libPortableRuntime.a(RuntimeInstance.cpp.o):(.data.rel.ro+0x2c): undefined reference to `RhpNewArrayAlign8'

jkotas · 2017-02-13T18:52:03Z

+
+// Allocate non-array object with finalizer.
+//  r0 == EEType
+    LEAF_ENTRY RhpNewFinalizable, _TEXT


It would be nice to make the implementation breakpoint to get nice crash for unimplemented parts once you start running the programs.

@jkotas Added breakpoints

jkotas · 2017-02-14T14:35:36Z

Thank you! I guess that the next one will have hello world working?

sergign60 · 2017-02-14T15:04:33Z

@jkotas
I hope so.

dnfclas added the cla-already-signed label Feb 8, 2017

jkotas reviewed Feb 8, 2017

View reviewed changes

sergign60 force-pushed the arm_build branch from 4534b2e to e0ebb2a Compare February 9, 2017 10:05

jkotas reviewed Feb 10, 2017

View reviewed changes

sergign60 force-pushed the arm_build branch from 4da11c0 to 60ae698 Compare February 13, 2017 10:19

sergign60 mentioned this pull request Feb 13, 2017

[Arm Unix build] arm variants of System.Native.a and libSystem.Globalization.Native.a are needed for cross building tests #2739

Open

jkotas reviewed Feb 13, 2017

View reviewed changes

Fixes for cross building corert tests for arm architectures on Linux

7259c7b

sergign60 force-pushed the arm_build branch from e8c6d19 to 7259c7b Compare February 14, 2017 11:49

jkotas approved these changes Feb 14, 2017

View reviewed changes

jkotas merged commit df1b120 into dotnet:master Feb 14, 2017

sergign60 deleted the arm_build branch February 14, 2017 15:17

Conversation

sergign60 commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfclas commented Feb 8, 2017

Uh oh!

sergign60 commented Feb 8, 2017

Uh oh!

jkotas Feb 8, 2017

Choose a reason for hiding this comment

Uh oh!

sergign60 Feb 9, 2017

Choose a reason for hiding this comment

Uh oh!

jkotas commented Feb 8, 2017

Uh oh!

jkotas commented Feb 8, 2017

Uh oh!

sergign60 commented Feb 9, 2017

Uh oh!

jkotas Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

sergign60 Feb 13, 2017

Choose a reason for hiding this comment

Uh oh!

sergign60 commented Feb 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergign60 commented Feb 13, 2017

Uh oh!

sergign60 commented Feb 13, 2017

Uh oh!

jkotas Feb 13, 2017

Choose a reason for hiding this comment

Uh oh!

sergign60 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

jkotas commented Feb 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergign60 commented Feb 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sergign60 commented Feb 8, 2017 •

edited

Loading

sergign60 commented Feb 13, 2017 •

edited

Loading

jkotas commented Feb 14, 2017 •

edited

Loading