This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Enhance virtual function resolution logic to be roughly correct.#27
Merged
Conversation
Member
davidwrighton
commented
Oct 6, 2015
davidwrighton
commented
- Add new api surface to MetadataType to allow MethodImpls to be queried
- Add new TypeSystemHelpers to allow finding of functions in similar type hierarchies (that only differ by instantiation
- Update the compilation logic to use new virtual function discovery logic
- Implement a first implementation of non-vtable based virtual function discovery. This implementation has been simulated in our pre-existing type system to be very similar to vtable based function discovery.
- Add new api surface to MetadataType to allow MethodImpls to be queried - Add new TypeSystemHelpers to allow finding of functions in similar type hierarchies (that only differ by instantiation - Update the compilation logic to use new virtual function discovery logic - Implement a first implementation of non-vtable based virtual function discovery. This implementation has been simulated in our pre-existing type system to be very similar to vtable based function discovery.
Member
There was a problem hiding this comment.
This method does not belong here. It would be nice to move it to more appropriate place while you are on it - maybe VirtualFunctionResolution.cs?
Member
|
LGTM otherwise |
davidwrighton
added a commit
that referenced
this pull request
Oct 6, 2015
Enhance virtual function resolution logic to be roughly correct.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.