Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Private.CoreLib/src/System/IO/Stream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ public override int ReadByte()

public override IAsyncResult BeginRead(byte[] buffer, int offset, int count, AsyncCallback callback, Object state)
{
throw new NotImplementedException();
throw new NotImplementedException(); // TODO: https://github.com/dotnet/corert/issues/3251
//bool overridesBeginRead = _stream.HasOverriddenBeginEndRead();

//lock (_stream)
Expand Down Expand Up @@ -712,7 +712,7 @@ public override void WriteByte(byte b)

public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, Object state)
{
throw new NotImplementedException();
throw new NotImplementedException(); // TODO: https://github.com/dotnet/corert/issues/3251
//bool overridesBeginWrite = _stream.HasOverriddenBeginEndWrite();

//lock (_stream)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public abstract partial class Assembly : ICustomAttributeProvider, ISerializable
public static Assembly GetEntryAssembly() => Internal.Runtime.CompilerHelpers.StartupCodeHelpers.GetEntryAssembly();

[System.Runtime.CompilerServices.Intrinsic]
public static Assembly GetExecutingAssembly() { throw new NotImplementedException(); }
public static Assembly GetExecutingAssembly() { throw NotImplemented.ByDesign; } //Implemented by toolchain.

public static Assembly GetCallingAssembly() { throw new PlatformNotSupportedException(); }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ public void OnDeserialization(object sender)
_siInfo = null;
}

public static AssemblyName GetAssemblyName(string assemblyFile) { throw new NotImplementedException(); }
public static bool ReferenceMatchesDefinition(AssemblyName reference, AssemblyName definition) { throw new NotImplementedException(); }
public static AssemblyName GetAssemblyName(string assemblyFile) { throw new NotImplementedException(); } // TODO: https://github.com/dotnet/corert/issues/3253
public static bool ReferenceMatchesDefinition(AssemblyName reference, AssemblyName definition) { throw new NotImplementedException(); } // TODO: https://github.com/dotnet/corert/issues/1861

internal static string EscapeCodeBase(string codebase) { throw new PlatformNotSupportedException(); }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public abstract partial class MethodBase : MemberInfo
public static MethodBase GetMethodFromHandle(RuntimeMethodHandle handle, RuntimeTypeHandle declaringType) => ReflectionAugments.ReflectionCoreCallbacks.GetMethodFromHandle(handle, declaringType);

[System.Runtime.CompilerServices.Intrinsic]
public static MethodBase GetCurrentMethod() { throw new NotImplementedException(); }
public static MethodBase GetCurrentMethod() { throw NotImplemented.ByDesign; } //Implemented by toolchain.

// This is not an api but needs to be declared public so that System.Private.Reflection.Core can access (and override it)
public virtual ParameterInfo[] GetParametersNoCopy() => GetParameters();
Expand Down