This repository was archived by the owner on Nov 1, 2020. It is now read-only.
CoreFx #15622 New overload Dictionary.Remove(K, out V)#3270
Merged
Conversation
safern
approved these changes
Apr 12, 2017
| return false; | ||
| } | ||
|
|
||
| public bool Remove(TKey key, out TValue value) |
Member
There was a problem hiding this comment.
Could we add comments that where added in CoreCLR PR as well?
safern
reviewed
Apr 12, 2017
| { | ||
| if (key == null) | ||
| { | ||
| value = default(TValue); |
Member
There was a problem hiding this comment.
Also, don't forget to remove this assignment as if we are throwing an Exception it doesn't make sense to change the out parameter value.
Contributor
Author
|
@safern Thanks much for pointing out. I had forgotten this PR! Please reviewthe changes that I have submitted... |
Member
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes equivalent to those in dotnet/corelr PR #10203 for the dotnet/corefx Issue #15622, PR #18109
@safern @danmosemsft @jkotas @karelz @stephentoub Please review.