Add tests for static field layout#33
Conversation
Porting native NUTC tests for static field layout to the new type system.
There was a problem hiding this comment.
Should we detect the architecture from the environment as opposed to hard-coding it?
There was a problem hiding this comment.
That would mean we can only test say - field layout for ARM64 - only when the test runs on an ARM64 device.
We should test other platforms, but we can run all the tests on all platforms irrespective of the current platform.
There was a problem hiding this comment.
If X64 is translated as "any 64bit" target, then the above works. However, what happens for 32bit (x86 vs Arm32)? If the target architecture is passed to the test infra at command-line (or such mechanism) that allows the architecture to be not hard-coded, your goal of running arm64 validations on x64 should still work.
There was a problem hiding this comment.
x64 is exactly AMD64 (or x86-64). Other 64 bit architectures might have e.g. different requirements for packing or alignments. I don't know and the type system doesn't know either (because all I implemented is x64).
|
LGTM |
Add tests for static field layout
3 participants
Porting native NUTC tests for static field layout to the new type
system.