This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Mirror changes from dotnet/coreclr#3345
Merged
Merged
Conversation
) Fix a few method names to better names used in CoreRT Contributes to #2966 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Member
|
@dotnet/corelib-contrib @MichalStrehovsky Could you please take a look at commit #2 that contains the CoreRT specific changes to make the Span compile? |
jkotas
force-pushed
the
mirror-merge-9093402
branch
from
4da090c to
52981c2
Compare
MichalStrehovsky
approved these changes
Apr 17, 2017
| } | ||
|
|
||
| // Bulk zero memory operation for large memory blocks | ||
| EXTERN_C REDHAWK_API void __cdecl RhZeroMemory(void* pMemStart, size_t cbMemSize) |
Member
There was a problem hiding this comment.
Does this need to be a new runtime service? Could the class library just p/invoke into memset, same as we already do for memmove?
| /// </summary> | ||
| [NonVersionable] | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static void InitBlockUnaligned(ref byte startAddress, byte value, uint byteCount) |
Member
There was a problem hiding this comment.
Add [Intrinsic] so that the new intrinsic kicks in?
jkotas
force-pushed
the
mirror-merge-9093402
branch
2 times, most recently
from
98dc3ed to
853664f
Compare
jkotas
force-pushed
the
mirror-merge-9093402
branch
from
853664f to
d24e0ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from dotnet/coreclr
Please REBASE this PR when merging