This repository was archived by the owner on Nov 1, 2020. It is now read-only.
String.Join optimization for single item lists#354
Merged
Conversation
…e item in the list
|
Hi @bbowyersmyth, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Member
|
LGTM |
Contributor
|
LGTM! |
AlexGhiondea
added a commit
that referenced
this pull request
Nov 21, 2015
String.Join optimization for single item lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port dotnet/coreclr#1460 to CoreRT.
Unlike CoreClr, CoreRT uses the StringBuilderCache in
Join(String, String[], int, int)so there was only 1 change to bring over there.