Get Array1 to work#36
Conversation
|
Why do the commits have "unknown" as author? |
There was a problem hiding this comment.
I don't think we should be updating this. Everyone has their own thing here and it will just cause unnecessary merge conflicts.
There was a problem hiding this comment.
If we add tests here, it will also make sure that we don't break what we built incrementally. I felt that a merge conflict is a smaller price to pay than debugging breaks.
There was a problem hiding this comment.
We will have a better plan for tests hopefully soon - leveraging CoreCLR test bed.
We do not have a team policy that everybody has to run this project before checking in right now; and everybody tends to have their own random thing here anyway ... so adding more stuff here does not ensure that things won't break.
|
LGTM otherwise |
|
One more nit: could you please delete "(with CR feedback)" from the commit description, and make it imperative (first word is a verb, without 'ing'). Check http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html on how to write good commit messages. |
- Add NewArr1 helper to the ReadyToRunHelper. - Create JitHelpers for static helpers: ex: RngChkFail. - Patch up the method table data for Array. - Throws bounds check for invalid access.
3 participants
@jkotas @MichalStrehovsky @JohnChen0
Could you please take a look? Both bounds check exception is thrown in the invalid case and the value is incremented for the array in the valid case. The test will return exit code 100 if passes.
Summary:
Add NewArr1 helper to the ReadyToRunHelper.
Created JitHelpers for static helpers like throw/rngchk.
Patching up the method table data for Array.
Add return value for Main and added test Jagged.