This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Add support for GC static fields#44
Merged
Merged
Conversation
Member
MichalStrehovsky
commented
Oct 9, 2015
MichalStrehovsky
commented
- Expose GC static size and alignment from MetadataType
- Add __assignReference JIT helper
- Emit GC static data section into the assembly file
Member
There was a problem hiding this comment.
This should just call WriteBarrier - maybe copy the implementation from Native\gc\sample\GCSample.cpp to the "repro" project until we get the right implementation from MRT?
Member
|
(Maybe there are better names AsmWriter.EEType.cs, EEType.AsmWriter.cs ... not sure.) |
* Expose GC static size and alignment from MetadataType * Add __assignReference JIT helper * Emit GC static data section into the assembly file
We were previously allocating the GC static region statically in the image, but for Ready to Run, we will require GC static regions to be allocated on the GC heap.
MichalStrehovsky
added a commit
that referenced
this pull request
Oct 12, 2015
Add support for GC static fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.