Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Thunks: support for fixed size thunk pool#8304

Merged
jkotas merged 2 commits into
dotnet:masterfrom
RalfKornmannEnvision:master
Sep 9, 2020
Merged

Thunks: support for fixed size thunk pool#8304
jkotas merged 2 commits into
dotnet:masterfrom
RalfKornmannEnvision:master

Conversation

@RalfKornmannEnvision
Copy link
Copy Markdown
Contributor

Provides the platform independent (OS and CPU architecture) runtime code to support a fixed size thunk pool for systems that doesn't support any way to add more thunks on demand.

Activated with FEATURE_FIXED_POOL_THUNKS..

FEATURE_RX_THUNKS will still override this.

The default is still the template based system.

The code blocks of the pool itself need to be either build and linked as part of the executable or generated by the compiler to be included in the object file.

Provides the platform independent (OS and CPU architecture) runtime code to support a fixed size thunk pool for systems that doesn't support any way to add more thunks on demand.

Activated with FEATURE_FIXED_POOL_THUNKS..

FEATURE_RX_THUNKS will still override this.

The default is still the template based system.

The code blocks of the pool itself need to be either build and linked as part of the executable or generated by the compiler to be included in the object file.
Comment thread src/Native/Runtime/ThunksMapping.cpp Outdated
* Thunks: support for fixed size thunk pool

Provides the platform independent (OS and CPU architecture) runtime code to support a fixed size thunk pool for systems that doesn't support any way to add more thunks on demand.

Activated with FEATURE_FIXED_POOL_THUNKS..

FEATURE_RX_THUNKS will still override this.

The default is still the template based system.

The code blocks of the pool itself need to be either build and linked as part of the executable or generated by the compiler to be included in the object file.

* Review changes

- Use PalVirtualAlloc instead of GCToOSInterface for memory operations
- Rename global variable to better match the usage
Copy link
Copy Markdown
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 5b0e2eb into dotnet:master Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants