Enable CFSClean* policies for dotnet-crank-ci-official pipeline#873
Enable CFSClean* policies for dotnet-crank-ci-official pipeline#873
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mmitche
force-pushed
the
enable-cfsclean-main
branch
from
8124211 to
e90a147
Compare
|
✅ Test build passed after fixing nuget.org references for CFSClean compliance. Passing build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2929815 Changes in this update:
|
| { | ||
| static TimeSpan CacheTimeout = TimeSpan.FromDays(1); | ||
| static string PackageVersionUrl = "https://api.nuget.org/v3-flatcontainer/microsoft.crank.controller/index.json"; | ||
| static string PackageVersionUrl = "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/flat2/microsoft.crank.controller/index.json"; |
There was a problem hiding this comment.
The dotnet tool which is installed from nuget.org is checking the nuget feed for new versions in order to display a warning. Should we care here?
There was a problem hiding this comment.
If it's installed from nuget.org...wouldn't there not ever be a newer package anyway?
| File.WriteAllText(rootNugetConfig, @"<?xml version=""1.0"" encoding=""utf-8""?> | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> |
There was a problem hiding this comment.
We should be fine since this is added to the root folder
| private static readonly string _dotnetInstallPs1Url = "https://dot.net/v1/dotnet-install.ps1"; | ||
| private static readonly string _perfviewUrl = $"https://github.com/Microsoft/perfview/releases/download/{PerfViewVersion}/PerfView.exe"; | ||
| private static readonly string _ultraUrl = $"https://www.nuget.org/api/v2/package/ultra/{UltraVersion}"; | ||
| private static readonly string _ultraUrl = $"https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/flat2/ultra/{UltraVersion}/ultra.{UltraVersion}.nupkg"; |
There was a problem hiding this comment.
@LoopedBard3 we need to update the package version and push it in the internal feed
There was a problem hiding this comment.
Pushed v1.3.0 and v2.0.2 to the feed. We can merge this as is and then update to v2.0.2 if we want.
3 participants
Adds CFSClean and CFSClean2 network isolation policies.