Merged
Conversation
- multiple event fields across multiple lines - default value assignment of each
Member
Yeah, Roslyn drives the semantic highlighting and was built to drive the highlighting in VS which has never had more specific keyword classifications. Perhaps, now that it also powers the C# LSP, we could push for additional details to be surfaced as token modifiers. CC: @dibarbet |
JoeRobich
approved these changes
Aug 2, 2023
Member
JoeRobich
left a comment
There was a problem hiding this comment.
Thank you so much for all these improvements!
Member
Tracking issue dotnet/vscode-csharp#5993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #118
P.S. All these PRs because the semantic highlighter marks every single keyword as
plainKeywordwhich overrides everything askeyword.cs, even if it already had more specific scope likekeyword.other.X.Y.cs.I just wanted separate colours for some special keywords so I turned off theme colour for
keyword.csand this happens...